Fix targeting bones and collision boxes of various units #5470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4067
Found renewed motivation after watching a Brick consistently being able to evade the laser of a Spiderbot in a cast
Long story short, this pull request evaluates almost all targeting bones and almost all collision boxes of almost all land units and almost all structures. Naval units were already processed in batches through #5447
This won't only have a positive impact on beam weapons. It also has a positive impact on the hit-ratio of gunships.
To summarize some of the problems that were encountered:
The general rule of thumb is that small units do not use target bones. The procedure to decipher where to aim when a unit has no target bones is in #4067 . Large units and structures use multiple target bones to make it more visually pleasing to see units firing at them.
Another general rule of thumb is that the vertical height of a unit should be at least
0.5
. If it is less, a projectile from a gunship may be confused and collide with the terrain directly below the unit instead of the unit itself