Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure games are ranked if an ACU was killed by the enemy team #109

Closed
Sheeo opened this issue Dec 31, 2015 · 4 comments
Closed

Make sure games are ranked if an ACU was killed by the enemy team #109

Sheeo opened this issue Dec 31, 2015 · 4 comments
Milestone

Comments

@Sheeo
Copy link
Member

Sheeo commented Dec 31, 2015

The early unrankedness feature is there to prevent early disconnects from affecting games and allowing players to opt out of rankedness in such cases.

This shouldn't apply to early rush strategies, so we must make sure to rank these games in all circumstances.

@Brutus5000
Copy link
Member

I would hook into the GameStatsService and inform the game about whethere ACUs haven been killed or not. Question: If a player leaves the game, his ACU is destroyed. Will this show up in the GameService as killed ACU?

@Brutus5000
Copy link
Member

Brutus5000 commented May 29, 2016

My new proposal is here: #143

@aeoncleanse
Copy link
Member

aeoncleanse commented Jul 6, 2016

Game side merged as FAForever/fa@4434984

@Brutus5000
Copy link
Member

Server side was merged as well. (Connects to #143).
This issue can be closed.

@Crotalus Crotalus closed this as completed Aug 8, 2016
@faf-bot faf-bot removed the ready label Aug 8, 2016
@micheljung micheljung modified the milestones: v0.3, v1.0 Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants