Fix wrong multi dispatch / Crash in multiple same-named routines #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all the multi calls go into the first candidate, which results in a Bool being unpacked into :returns and :&test. On latest Rakudos, Bool.Capture was made to throw precicely to catch this sort of bugs. Fix by adding proper type contraints so dispatch happens to right candidates.
Since subs are lexical, it's possible to add more than one sub with the same name. This causes a crash because hash is type-constrainted to Routine, but Hash.push with existing key creates an Array there. Fix by removing that type constraint and modifying run-tests routine to be able to handle multi-named subs in a key.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.