Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15 #296

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Angular 15 #296

wants to merge 5 commits into from

Conversation

oobayly
Copy link
Contributor

@oobayly oobayly commented Feb 22, 2023

When I created #278 I [stupidly] targeted Angular 14, which has meant that the package can't be used with Angular 13 - something that's just bitten me in the a**. Also noted in #282

This PR reverts the build version to Angular 12 (v.2.2.2), but updates the peer dependencies to <=15.x (#292)

Initially, I want to check that this builds correctly on CircleCI CircleCI passes now, and I appreciate that releasing a package version that targets a lower Angular version may be problematic.

My next task is to try using this in an angular app starting with 12 to make sure I haven't screwed anything up.

  • Install, and run on Angular 12
  • Install, and run on Angular 13
  • Install, and run on Angular 14
  • Install, and run on Angular 15
  • Install on Angular 12, and upgrade incrementally to Angular 15

I've also included the following:

@CarnsJalone
Copy link

Bumping this thread. Is there any momentum to have this pull request reviewed and merged.

@mlangwell
Copy link

We could really use this PR merged for our team. It is preventing us from completing our update to Angular 15 since we use this package.

@lazybobcat
Copy link

same here, this is the last package preventing us from updating to Angular 15

@oobayly
Copy link
Contributor Author

oobayly commented Mar 10, 2023

For those of you feeling brave, I've attached a zip file of the tarball (GitHub does't support attaching tarballs), from which you can do a local install. This is what I've done with my current project as I really don't want to have to publish an NPM package.

angular-google-charts-2.2.3.tgz.zip

@HenriqueEichstadt
Copy link

Is there a deadline for approving this pull request?

@funat
Copy link

funat commented May 5, 2023

Same question here - this library is th only one blocking us to move the project to Angular 15.

@CristoferEichstadt
Copy link

Is there a deadline for approving this pull request?

@mohamed-badaoui
Copy link

update to peer dependencies to 16.x ?

@diegoberges
Copy link

Approves the PR, please.

@sgovorov
Copy link

Is there a possibility to update dependencies to 16.x?

@mohamed-badaoui
Copy link

Is there a possibility to update dependencies to 17.x?

@maurodam
Copy link

maurodam commented May 1, 2024

Why doesn't anyone maintain this project anymore and approve pull requests?
If this library is no longer maintained, can't you manage to duplicate, create a new package and take over for future updates?
Citing the creator of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet