Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstructionCountCI: add bytemark hot block #3652

Merged
merged 1 commit into from
May 22, 2024
Merged

InstructionCountCI: add bytemark hot block #3652

merged 1 commit into from
May 22, 2024

Conversation

alyssarosenzweig
Copy link
Collaborator

this was basically practice for using perf with FEX, but a few things do stand out in the assembly as suboptimal.

@alyssarosenzweig
Copy link
Collaborator Author

Ideally, this would be:

        "ldr x17, [x10, x13, lsl #3]",
        "orr x15, x13, #0x1",
        "ldr x20, [x10, x15, lsl #3]",
        "eor w27, w17, w20",
        "subs x26, x17, x20",
        "cfinv"

or even (with multiblock flag optimizations)

        "ldr x17, [x10, x13, lsl #3]",
        "orr x15, x13, #0x1",
        "ldr x20, [x10, x15, lsl #3]",
        "cmp x17, x20",

@alyssarosenzweig
InstructionCountCI: add bytemark hot block
9f243c8 
this was basically practice for using perf with FEX, but a few things do stand
out in the assembly as suboptimal.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
@lioncash lioncash merged commit 063b1eb into FEX-Emu:main May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssarosenzweig @lioncash