Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ffc-x interface for integrals #15

Closed
garth-wells opened this issue Apr 10, 2018 · 2 comments
Closed

New ffc-x interface for integrals #15

garth-wells opened this issue Apr 10, 2018 · 2 comments
Projects
Milestone

Comments

@garth-wells
Copy link
Member

garth-wells commented Apr 10, 2018

From @chrisrichardson

At the moment, ffc generates tabulate_tensor() code for integrals in several ufc::foointegral classes, for cell, interior_facet, exterior_facet, vertex etc. The class also contains an enabled_coefficients() function (can we eliminate?)

Should we use a common function signature for all integrals?
e.g.
void tabulate_tensor(double *A, const double* w, const double* coords, const int* entity_indices);

(for integrals over multiple cells: "macro", the data can be stacked for each argument).
We can store the integrals as std::function<> or just as raw C function pointers (may be more efficient).

[x] signature for cell
[x] signature for interior_facet
[x] signature for exterior_facet
[x] signature for vertex
[] signature for custom integral

@garth-wells
Copy link
Member Author

Fixing this will address #33.

@chrisrichardson
Copy link
Contributor

Closing, as this is 90% done. Remaining issue is for custom integrals.

Assembler automation moved this from In progress to Done Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Assembler
  
Done
Development

No branches or pull requests

2 participants