Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from defined words #239

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Conversation

JeromeMartinez
Copy link
Contributor

From Barry Leiba's Discuss:

General: It’s jarring to see the defined terms, such as “Sample” and “Pixel” in
quotes every time they’re used. More common practice is to quote them when
they’re first defined, and then to just use the capitalization to show that
they’re defined terms. I find that the quotes affect the readability and make
it somewhat more of a challenge to read.

So I removed quotes from defined words.
As Frame is not only a defined word but also a part of the bitstream, it is not just a find and replace, so maybe some double check to do.

I also added the missing definition of Line.

@michaelni
Copy link
Member

Does not apply cleanly to master/HEAD anymore "This branch has conflicts that must be resolved"

@JeromeMartinez
Copy link
Contributor Author

PR udpated for including changes from #238, no more conflicts.

@michaelni michaelni merged commit f0eb24b into FFmpeg:master Oct 4, 2020
@JeromeMartinez JeromeMartinez deleted the Quotes branch October 4, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants