Ballot Barry part 2 #241
Merged
Ballot Barry part 2 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeromeMartinez
force-pushed
the
Ballot_Barry
branch
from
00442b9
to
3f7abca
Compare
|
Is it useful to mention |
JeromeMartinez
force-pushed
the
Ballot_Barry
branch
from
3f7abca
to
0dd2ae0
Compare
Checking if we use |
dericed
reviewed
Oct 5, 2020
JeromeMartinez
force-pushed
the
Ballot_Barry
branch
from
0dd2ae0
to
d6fbc97
Compare
retokromer
approved these changes
Oct 6, 2020
dericed
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
I re-reviewed and this looks good. Is this PR is the last part of responding to Barry Leiba's review?
dericed
approved these changes
Oct 6, 2020
|
The only missing part is the get_rac stuff. |
|
@JeromeMartinez I'll move the get_rac discussion to that issue as I think this PR is ready for merge. hoping @michaelni agrees :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of patches partially fixing Barry Leiba's Discuss.