-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ballot Barry part 2 #241
Ballot Barry part 2 #241
Conversation
00442b9
to
3f7abca
Compare
Is it useful to mention |
3f7abca
to
0dd2ae0
Compare
Checking if we use |
0dd2ae0
to
d6fbc97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-reviewed and this looks good. Is this PR is the last part of responding to Barry Leiba's review?
The only missing part is the get_rac stuff. |
@JeromeMartinez I'll move the get_rac discussion to that issue as I think this PR is ready for merge. hoping @michaelni agrees :) |
A couple of patches partially fixing Barry Leiba's Discuss.