New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
section 3.8.1.2 needs to define get_rac #230
Comments
https://github.com/dwbuiten/go-ffv1/blob/master/ffv1/rangecoder/range.go |
Worth noting here that when I implemented go-ffv1, it was with an older revision of the spec, and it seems the figure numbers have since changed... I'll update the comments. (Also worth noting that go-ffv1 is not an official reference decoder.) |
Hi @dwbuiten, you could contextualize your comments to the version of the draft such as "draft-ietf-cellar-ffv1-17", although as the document is in "IESG Evaluation" status the RFC number may be soon. |
Yes, I'll do that when I update them. |
@dwbuiten, @michaelni, are you able to assist with the get_rac piece of Barry's review. The quote from the review is
I understand that get_rac refers to figure 9; however a narrative could help. For instance does |
IIRC get_rac() was named for consistancy with get_cabac(), it returns a single bit coded using the range coder. Not sure if the 3 letters can be matched to grammatically 100% fitting words |
As per Barry Lieba review, the section 3.8.1.2 says:
but it is not defined, and likely relates to the decode process.
The text was updated successfully, but these errors were encountered: