Add pseudocode examples for Range Binary Values #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ```c | ||
| range = 0xFF00; | ||
| end = 0; | ||
| low = get_bits(16); |
There was a problem hiding this comment.
In theory, couldn't the bitstream be 1-byte long?
In my implementation of the range coder decoding I have something more like:
range = 0xFF;
end = 0;
low = get_bits(8);
refill();(with refill() moved above this text)
The reference decoder does not handle a 1-byte Slice and in practice the specification currently prevents a so small Slice due to the count of fields in it, but in the future it could be the case.
Maybe we would update the spec at the same time as the reference decoder if a 1-byte Slice is possible in practice...
There was a problem hiding this comment.
I don't really have a strong opinion on the matter.
dwbuiten
changed the title
JeromeMartinez
approved these changes
Oct 4, 2020
dericed
approved these changes
Oct 5, 2020
retokromer
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #230 and #231.
First pass at adding pseudocode for these (maybe a little rough). Please review.
I am particularily unsure that
remaining_bits_in_bitstream()is the correct way to say "no bits left to read in the buffer".CC: @michaelni @JeromeMartinez @dericed @mcr