Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve client API to do proper waits #44

Closed
kood1 opened this issue Oct 16, 2014 · 1 comment
Closed

Improve client API to do proper waits #44

kood1 opened this issue Oct 16, 2014 · 1 comment
Labels
enhancement

Comments

@kood1
Copy link
Member

kood1 commented Oct 16, 2014

Instead of having users add arbitrary timeouts in their tests, we should add proper waits in our client API. For example, when we send setInterceptXHR(), we should wait until a response comes back from msl-server confirming the registration completed successfully.
@kood1 kood1 mentioned this issue Oct 21, 2014
Closed
@kood1
Copy link
Member Author

kood1 commented Oct 21, 2014

#51 should fix this problem

@kood1 kood1 closed this as completed Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kood1