Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox Authentication modifications (Using external browser and PKCE implementation) #38

Merged
merged 29 commits into from
Dec 30, 2020

Conversation

FJBDev
Copy link
Owner

@FJBDev FJBDev commented Dec 29, 2020

Authorization process for new users

  • Go to Preferences ➡️ Cloud Connectivity ➡️ Dropbox
  • Click on the button "Authorize"

image

  • Your system's default browser will open
  • Click on "Continue"

image

  • Click on "Accept"
    image

  • The authorization process is complete and you can close your browser

image

  • The token information will be populated in the preferences

image

  • You can now create Dropbox folders in the Easy Import Manager
    image

Authorization process for previous users

  • Your current Dropbox folders will not work anymore
    image

  • Go to Preferences ➡️ Cloud Connectivity ➡️ Dropbox

  • Click on the button "Authorize"

image

  • Your system's default browser will open
  • Click on "Continue"

image

  • Click on "Accept"
    image

  • The authorization process is complete and you can close your browser

image

  • The token information will be populated in the preferences

image

  • You can now use again your different Dropbox folders in the Easy Import Manager
    image

@FJBDev FJBDev changed the title Dropbox Authentication modifications (Using external browser and PKCE implementation Dropbox Authentication modifications (Using external browser and PKCE implementation) Dec 30, 2020
@FJBDev FJBDev merged commit 1c228e8 into main Dec 30, 2020
FJBDev added a commit that referenced this pull request Jan 3, 2021
… implementation) (mytourbook#277)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours
FJBDev added a commit that referenced this pull request Jan 5, 2021
* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos
FJBDev added a commit that referenced this pull request Jan 8, 2021
* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* [SRTM] test connection to server failed with old default value, however the srtm data retrieval worked

Connection test failed for https://dds.cr.usgs.gov/srtm/version2_1
Returncode: 301  <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="http://dds.cr.usgs.gov/srtm/version2_1/">here</a>.</p>
</body></html>

Only the last / in the url was missing

* Per code review

* Removing slf4j warnings

Co-authored-by: wolfgang-ch <wolfgang-ch@users.sourceforge.net>
FJBDev added a commit that referenced this pull request Jan 11, 2021
* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* [SRTM] test connection to server failed with old default value, however the srtm data retrieval worked

Connection test failed for https://dds.cr.usgs.gov/srtm/version2_1
Returncode: 301  <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="http://dds.cr.usgs.gov/srtm/version2_1/">here</a>.</p>
</body></html>

Only the last / in the url was missing

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

Co-authored-by: wolfgang-ch <wolfgang-ch@users.sourceforge.net>
FJBDev added a commit that referenced this pull request Jan 13, 2021
* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date
@FJBDev FJBDev deleted the main-dropbox-fix branch January 13, 2021 17:33
FJBDev added a commit that referenced this pull request Jan 22, 2021
…nts and fixes (mytourbook#291)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* TCX Export Enhancement and fixes (mytourbook#287)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* Missed commiting that file

* [Bug] fixed NPE which occurred

* Adding the possibility to configure a User Agent for each map provider (#42)

* [FIT Import] implementing HRV-RR values

* Added the possibility to export the current map view to an image file (jpg, png or bmp)

* Activating the FitLog and FitLogEx unit tests (#45)

* [Import] changed mnemonic to prevent duplication with re-import

* [HRV-RR] Testing how to display bpm values computed with pulse times

* Renaming the action text and adding a tooltip

* Improvements after more testing

* Adding the action to export the map view in the clipboard

* No image

* 2 in 1

* Adding source

* French translation

* [Tour Chart] Added chart type to draw a graph with dots, this is available only for "debugging"

* [HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time

* Indentation

* Code improvement

* Revert

* Fixed a bug where the authentication would not work if the browser's
response was too long (in french for example). Fixed the browser's
response for languages with accents

* Using the Http Constant

* Using the Http Constant

* Code improvements

* [HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time

* putting the export actions into a submenu action

* Found code to polish when I inspired myself for the export map submenu

* Adding tooltip for the searchtourbylocation

* [HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time

* [HRV-RR] Implemented 2nd pulse graph to display bpm from R-R intervalstime

* Readme update

* Unit tests update

Co-authored-by: wolfgang-ch <wolfgang-ch@users.sourceforge.net>
FJBDev added a commit that referenced this pull request Jan 23, 2021
* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* TCX Export Enhancement and fixes (mytourbook#287)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* Missed commiting that file

* [Bug] fixed NPE which occurred

* Adding the possibility to configure a User Agent for each map provider (#42)

* [FIT Import] implementing HRV-RR values

* Added the possibility to export the current map view to an image file (jpg, png or bmp)

* Activating the FitLog and FitLogEx unit tests (#45)

* [Import] changed mnemonic to prevent duplication with re-import

* [HRV-RR] Testing how to display bpm values computed with pulse times

* Renaming the action text and adding a tooltip

* Improvements after more testing

* Adding the action to export the map view in the clipboard

* No image

* 2 in 1

* Adding source

* French translation

* [Tour Chart] Added chart type to draw a graph with dots, this is available only for "debugging"

* [HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time

* Indentation

* Code improvement

* Revert

* Fixed a bug where the authentication would not work if the browser's
response was too long (in french for example). Fixed the browser's
response for languages with accents

* Using the Http Constant

* Using the Http Constant

* Code improvements

* [HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time

* putting the export actions into a submenu action

* Found code to polish when I inspired myself for the export map submenu

* Adding tooltip for the searchtourbylocation

* [HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time

* [HRV-RR] Implemented 2nd pulse graph to display bpm from R-R intervalstime

* Readme update

* Unit tests update

* Per code review

* Genericizing the heroku app to make room for the Suunto Cloud
integration

* No need for Heroku to get the auth code and it's much faster!

* [Readme] todo update

* Fix for the clipboard not working in windows

* When the map image is pasted into the clipboard, then it would be
helpful for the user when there is some sort of notification.

* Added the ability to compress jpg files

* Fix for the user-agent UI alignment

* Date

* Duplicated

* revert

* Fixing the UI alignment issue

* No : in the labels

* Removing more :

Co-authored-by: wolfgang-ch <wolfgang-ch@users.sourceforge.net>
FJBDev added a commit that referenced this pull request Jan 25, 2021
* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* TCX Export Enhancement and fixes (mytourbook#287)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* Missed commiting that file

* Adding the possibility to configure a User Agent for each map provider (#42)

* Added the possibility to export the current map view to an image file (jpg, png or bmp)

* Activating the FitLog and FitLogEx unit tests (#45)

* Renaming the action text and adding a tooltip

* Improvements after more testing

* Adding the action to export the map view in the clipboard

* No image

* 2 in 1

* Adding source

* French translation

* Indentation

* Code improvement

* Revert

* Fixed a bug where the authentication would not work if the browser's
response was too long (in french for example). Fixed the browser's
response for languages with accents

* Using the Http Constant

* Using the Http Constant

* Code improvements

* putting the export actions into a submenu action

* Found code to polish when I inspired myself for the export map submenu

* Adding tooltip for the searchtourbylocation

* Readme update

* Unit tests update

* Per code review

* Genericizing the heroku app to make room for the Suunto Cloud
integration

* No need for Heroku to get the auth code and it's much faster!

* Fix for the clipboard not working in windows

* When the map image is pasted into the clipboard, then it would be
helpful for the user when there is some sort of notification.

* Added the ability to compress jpg files

* Fix for the user-agent UI alignment

* Date

* Duplicated

* revert

* Fixing the UI alignment issue

* No : in the labels

* Removing more :

* Merge

* Merge

* Merge

* Last merge

* Code rearranging

* Reverting to Wolfgang's code as I should not modify it

* Reverting to Wolfgang's code

* French translation

* Adding the tour upload in the rawdataview contextual menu

* French typo

* Using JSONObject to build a json payload in a nicer way

* Code improvements
FJBDev added a commit that referenced this pull request Jan 26, 2021
…evious PR code review (mytourbook#295)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* TCX Export Enhancement and fixes (mytourbook#287)

* Changes per code review

* Removing the harmless ResourceNotFoundException

* Putting it back

* We clear the browser session so that a user can log in with different
accounts

* Misc

* Useless

* Making the Strava upload asynchronous to speed up the upload

* Renaming the field per Wolfgang suggestion

* Putting fields, which belong together, into { ... }, for better
readability

* displaying the account user name in the upload dialog

* Misc

* Export Unit tests update and successful

* Unit tests

* Unit tests update after this fix
20bb310

* XML Unit 2.8.2

* Using OauthConstants

* Typo

* Unit tests update

* Dropbox Authentication modifications (Using external browser and PKCE implementation) (#38)

* Readme update

* Misc

* Adding the number of tours in the progress bar message

* Translation typos

* Trying to renew the token right before uploading the tours

* Default button is now at the bottom of the page

* Putting constructLocalExpireAtDateTime in TimeTools for reuse

* the icon is at the beginning of the line and the dots are removed

* removing the prefstore listener when closed

* 2021

* Removing the colons from the labels

* Misc

* Use a more random number for the port (4917) and displyaing an error
message if it's not available.

* Misc

* Changing the Dropbox Url

* Using the external browser for Strava as well

* Misc

* Misc

* Upper case for public fields

* Protected

* Misc improvements

* English typos

* Removing the code that is too context specific

* Expires At is now at the bottom

* V2 ?

* Per code review

* Removing slf4j warnings

* Adding the ability to upload manual tours to Strava (#40)

* Renaming

* No dot

* TCX Export Enhancement and fixes (#41)

* Readme update

* Misc

* Stopping the server when leaving the preference page

* SOnarLint

* Misc

* Date

* Missed commiting that file

* Adding the possibility to configure a User Agent for each map provider (#42)

* Added the possibility to export the current map view to an image file (jpg, png or bmp)

* Activating the FitLog and FitLogEx unit tests (#45)

* Renaming the action text and adding a tooltip

* Improvements after more testing

* Adding the action to export the map view in the clipboard

* No image

* 2 in 1

* Adding source

* French translation

* Indentation

* Code improvement

* Revert

* Fixed a bug where the authentication would not work if the browser's
response was too long (in french for example). Fixed the browser's
response for languages with accents

* Using the Http Constant

* Using the Http Constant

* Code improvements

* putting the export actions into a submenu action

* Found code to polish when I inspired myself for the export map submenu

* Adding tooltip for the searchtourbylocation

* Readme update

* Unit tests update

* Per code review

* Genericizing the heroku app to make room for the Suunto Cloud
integration

* No need for Heroku to get the auth code and it's much faster!

* Fix for the clipboard not working in windows

* When the map image is pasted into the clipboard, then it would be
helpful for the user when there is some sort of notification.

* Added the ability to compress jpg files

* Fix for the user-agent UI alignment

* Date

* Duplicated

* revert

* Fixing the UI alignment issue

* No : in the labels

* Removing more :

* [NPE] fixed NPE

* Merge

* Merge

* Merge

* Last merge

* Code rearranging

* Reverting to Wolfgang's code as I should not modify it

* Reverting to Wolfgang's code

* French translation

* Adding the tour upload in the rawdataview contextual menu

* French typo

* Using JSONObject to build a json payload in a nicer way

* Code improvements

* [Readme] todo update

* [Fit Import] reenabled logging

* Because the user agent default is set to an empty string, this will
never be null, so we should check if it's null (just in case) or empty

* Renaming the tooltip message variable as the field is now a label

* The 3rd text key part should be the UI control name

* Fixing a possible NPE

* Displaying JPEG instead of JPG except for the file extension

* Using the word quality instead of compression

* Code improvements and tests

* JPEG is always written in uppercase

* When Quality cannot be set on Linux, it should be disabled that nobody
can complain that it is not working

* We need to dispose the clipboard

* Workaround to putting the map in the clipboard

* Readme update

Co-authored-by: wolfgang-ch <wolfgang-ch@users.sourceforge.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant