-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt#2: New features, TCX Export Enhancement, unit tests enhancements and fixes #291
Conversation
… implementation) (#38)
Conflicts: info/release-notes/21.next.0-readme.txt
…lable only for "debugging"
response was too long (in french for example). Fixed the browser's response for languages with accents
Conflicts: info/release-notes/21.next.0-readme.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not yet done with this review but for today it is enough
bundles/net.tourbook/src/de/byteholder/geoclipse/mapprovider/DialogMPCustom.java
Show resolved
Hide resolved
bundles/net.tourbook/src/de/byteholder/geoclipse/mapprovider/DialogMPProfile.java
Show resolved
Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/view/DialogMap2ExportViewImage.java
Show resolved
Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/view/DialogMap2ExportViewImage.java
Show resolved
Hide resolved
I have fixed all the issued from your comments of today but I will wait for your finalized review to create a new PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now the final code review for this PR
See original PR that failed to merge and this PR
Unit tests 100%% successful: