Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sshd] add @Tjzabel as authorized user to irc-lug.rit.edu #26

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

jwflory
Copy link
Member

@jwflory jwflory commented Dec 7, 2018

This is an old action item I've had on my plate, but this PR adds @Tjzabel as an authorized user to the irc-lug.rit.edu host. This change is tested and also deployed to production already.


Needs testing

@Tjzabel: are you able to SSH into the machine now?

Details

Sort of interesting how I did this. Originally, I had a global target user defined for this entire repository, but I am realizing this doesn't scale. I tried out something new and added some variables to the sshd role with a list of authorized users and their SSH public keys. Then I loop through the list in the role's tasks, and ta-da! It works.

Something I am wondering: does it make more sense to define these users globally or only in this specific role? Probably yes, since @Tjzabel isn't a member of the teleirc or matterbridge groups, which grant read/write privileges to private files in the deployment directories. I'll try and get that in a future PR.

@jwflory jwflory added T: ansible:roles Related to Ansible roles improvement Improves on something that already exists labels Dec 7, 2018
@jwflory jwflory self-assigned this Dec 7, 2018
@jwflory jwflory added this to In progress in FOSS@MAGIC operations via automation Dec 7, 2018
@jwflory jwflory requested a review from Tjzabel December 7, 2018 21:10
@Tjzabel
Copy link
Member

Tjzabel commented Dec 7, 2018

@jwflory Thanks for doing this! I will test this out over the weekend, and let you know the results.

@jwflory
Copy link
Member Author

jwflory commented Jan 4, 2019

@Tjzabel Ping – were you able to SSH into the machine?

@jwflory
Copy link
Member Author

jwflory commented Jan 4, 2019

I have a new change coming in that is based off of this. I have good reason to believe this change is in place. I'm merging this PR. 🎬

@jwflory jwflory merged commit dacc69f into master Jan 4, 2019
FOSS@MAGIC operations automation moved this from In progress to Done Jan 4, 2019
@jwflory jwflory deleted the add/tjzabel21-irc-lug branch January 4, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves on something that already exists T: ansible:roles Related to Ansible roles
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants