Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: strncmp -> strcmp in community hash foo #10485

Merged
merged 1 commit into from
Feb 3, 2022
Merged

bgpd: strncmp -> strcmp in community hash foo #10485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions bgpd/bgp_community_alias.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ static bool bgp_ca_community_hash_cmp(const void *p1, const void *p2)
const struct community_alias *ca1 = p1;
const struct community_alias *ca2 = p2;

return (strncmp(ca1->community, ca2->community,
sizeof(struct community_alias))
== 0);
return (strcmp(ca1->community, ca2->community) == 0);
}

static unsigned int bgp_ca_alias_hash_key(const void *p)
Expand All @@ -57,8 +55,7 @@ static bool bgp_ca_alias_hash_cmp(const void *p1, const void *p2)
const struct community_alias *ca1 = p1;
const struct community_alias *ca2 = p2;

return (strncmp(ca1->alias, ca2->alias, sizeof(struct community_alias))
== 0);
return (strcmp(ca1->alias, ca2->alias) == 0);
}

static void *bgp_community_alias_alloc(void *p)
Expand Down