move interface ( LINK and ADDR ) events to the dplane #13396

donaldsharp · 2023-04-27T03:09:23Z

see individual commits, but effectively move LINK and ADDR kernel events to the dplane.

donaldsharp · 2023-04-27T03:10:28Z

I think I need another round of cleanup of debugs that I moved into interface.c, but I'll do that soon

NetDEF-CI · 2023-04-27T03:45:23Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11149/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'interface_vrf_change':
zebra/interface.c:1504:15: error: implicit declaration of function 'vrf_lookup_by_table'; did you mean 'vrf_lookup_by_name'? [-Werror=implicit-function-declaration]
 1504 |    exist_id = vrf_lookup_by_table(tableid, ns_id);
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit' [-Werror=implicit-function-declaration]
 1658 |  bool frr_protodown_r_bit = if_netlink_get_frr_protodown_r_bit();
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11149/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11149/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'interface_vrf_change':
zebra/interface.c:1504:15: error: implicit declaration of function 'vrf_lookup_by_table'; did you mean 'vrf_lookup_by_name'? [-Werror=implicit-function-declaration]
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit'; did you mean 'dplane_ctx_get_ifp_protodown_set'? [-Werror=implicit-function-declaration]
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11149/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11149/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1504:15: error: implicit declaration of function 'vrf_lookup_by_table' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
zebra/interface.c:1504:15: note: did you mean 'vrf_lookup_by_name'?
./lib/vrf.h:103:20: note: 'vrf_lookup_by_name' declared here

OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI011BUILD/config.log/config.log.gz
OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI011BUILD/config.status/config.status

Successful on other platforms/tests

Ubuntu 18.04 arm7 build
CentOS 7 amd64 build
Ubuntu 16.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 i386 build
Redhat 9 amd64 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 16.04 arm8 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 arm8 build
Ubuntu 22.04 amd64 build
Ubuntu 20.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11149/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'interface_vrf_change':
zebra/interface.c:1504:15: error: implicit declaration of function 'vrf_lookup_by_table'; did you mean 'vrf_lookup_by_name'? [-Werror=implicit-function-declaration]
 1504 |    exist_id = vrf_lookup_by_table(tableid, ns_id);
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit' [-Werror=implicit-function-declaration]
 1658 |  bool frr_protodown_r_bit = if_netlink_get_frr_protodown_r_bit();
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11149/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11149/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'interface_vrf_change':
zebra/interface.c:1504:15: error: implicit declaration of function 'vrf_lookup_by_table'; did you mean 'vrf_lookup_by_name'? [-Werror=implicit-function-declaration]
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit'; did you mean 'dplane_ctx_get_ifp_protodown_set'? [-Werror=implicit-function-declaration]
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11149/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11149/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1504:15: error: implicit declaration of function 'vrf_lookup_by_table' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
zebra/interface.c:1504:15: note: did you mean 'vrf_lookup_by_name'?
./lib/vrf.h:103:20: note: 'vrf_lookup_by_name' declared here

OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI011BUILD/config.log/config.log.gz
OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11149/artifact/CI011BUILD/config.status/config.status

Report for if_netlink.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #683: FILE: /tmp/f1-2346165/if_netlink.c:683:
< WARNING: void function return statements are not generally useful
< #740: FILE: /tmp/f1-2346165/if_netlink.c:740:
Report for interface.c | 46 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1549: FILE: /tmp/f1-2346165/interface.c:1549:
< WARNING: Block comments use a trailing */ on a separate line
< #1549: FILE: /tmp/f1-2346165/interface.c:1549:
< ERROR: do not use assignment in if condition
< #1555: FILE: /tmp/f1-2346165/interface.c:1555:
< WARNING: Block comments use a trailing */ on a separate line
< #2028: FILE: /tmp/f1-2346165/interface.c:2028:
< WARNING: Missing a blank line after declarations
< #2068: FILE: /tmp/f1-2346165/interface.c:2068:
< WARNING: Block comments use a trailing */ on a separate line
< #2082: FILE: /tmp/f1-2346165/interface.c:2082:
< WARNING: Missing a blank line after declarations
< #2101: FILE: /tmp/f1-2346165/interface.c:2101:
< WARNING: Block comments use a trailing */ on a separate line
< #2115: FILE: /tmp/f1-2346165/interface.c:2115:
< WARNING: line over 80 characters
< #2131: FILE: /tmp/f1-2346165/interface.c:2131:
< WARNING: Too many leading tabs - consider code refactoring
< #2135: FILE: /tmp/f1-2346165/interface.c:2135:
< WARNING: line over 80 characters
< #2144: FILE: /tmp/f1-2346165/interface.c:2144:
< WARNING: Block comments use a trailing */ on a separate line
< #2171: FILE: /tmp/f1-2346165/interface.c:2171:
< WARNING: C99 // comments do not match recommendation
< #2232: FILE: /tmp/f1-2346165/interface.c:2232:
< WARNING: C99 // comments do not match recommendation
< #2233: FILE: /tmp/f1-2346165/interface.c:2233:
< WARNING: C99 // comments do not match recommendation
< #2234: FILE: /tmp/f1-2346165/interface.c:2234:
< WARNING: C99 // comments do not match recommendation
< #2235: FILE: /tmp/f1-2346165/interface.c:2235:
< WARNING: C99 // comments do not match recommendation
< #2236: FILE: /tmp/f1-2346165/interface.c:2236:
< WARNING: C99 // comments do not match recommendation
< #2237: FILE: /tmp/f1-2346165/interface.c:2237:
< WARNING: C99 // comments do not match recommendation
< #2238: FILE: /tmp/f1-2346165/interface.c:2238:
< WARNING: C99 // comments do not match recommendation
< #2239: FILE: /tmp/f1-2346165/interface.c:2239:
< WARNING: C99 // comments do not match recommendation
< #2241: FILE: /tmp/f1-2346165/interface.c:2241:
< WARNING: C99 // comments do not match recommendation
< #2242: FILE: /tmp/f1-2346165/interface.c:2242:
< WARNING: C99 // comments do not match recommendation
< #2243: FILE: /tmp/f1-2346165/interface.c:2243:

NetDEF-CI · 2023-04-27T04:27:43Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11150/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit' [-Werror=implicit-function-declaration]
 1658 |  bool frr_protodown_r_bit = if_netlink_get_frr_protodown_r_bit();
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)
 1973 |   if (family == AF_BRIDGE)
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11150/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11150/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
zebra/interface.c:1973:17: error: use of undeclared identifier 'AF_BRIDGE'
2 errors generated.

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11150/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11150/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit'; did you mean 'dplane_ctx_get_ifp_protodown_set'? [-Werror=implicit-function-declaration]
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10517: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11150/frr-source'

Successful on other platforms/tests

Ubuntu 16.04 arm7 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 i386 build
CentOS 7 amd64 build
Ubuntu 16.04 arm8 build
Redhat 9 amd64 build
Ubuntu 18.04 amd64 build
Debian 11 amd64 build
Ubuntu 16.04 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 20.04 amd64 build
Ubuntu 22.04 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11150/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit' [-Werror=implicit-function-declaration]
 1658 |  bool frr_protodown_r_bit = if_netlink_get_frr_protodown_r_bit();
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)
 1973 |   if (family == AF_BRIDGE)
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11150/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11150/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
zebra/interface.c:1973:17: error: use of undeclared identifier 'AF_BRIDGE'
2 errors generated.

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11150/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11150/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11150/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'is_if_protodown_reason_only_frr':
zebra/interface.c:1658:29: error: implicit declaration of function 'if_netlink_get_frr_protodown_r_bit'; did you mean 'dplane_ctx_get_ifp_protodown_set'? [-Werror=implicit-function-declaration]
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10517: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11150/frr-source'

Report for if_netlink.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #683: FILE: /tmp/f1-2529533/if_netlink.c:683:
< WARNING: void function return statements are not generally useful
< #740: FILE: /tmp/f1-2529533/if_netlink.c:740:
Report for interface.c | 46 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1549: FILE: /tmp/f1-2529533/interface.c:1549:
< WARNING: Block comments use a trailing */ on a separate line
< #1549: FILE: /tmp/f1-2529533/interface.c:1549:
< ERROR: do not use assignment in if condition
< #1555: FILE: /tmp/f1-2529533/interface.c:1555:
< WARNING: Block comments use a trailing */ on a separate line
< #2028: FILE: /tmp/f1-2529533/interface.c:2028:
< WARNING: Missing a blank line after declarations
< #2068: FILE: /tmp/f1-2529533/interface.c:2068:
< WARNING: Block comments use a trailing */ on a separate line
< #2082: FILE: /tmp/f1-2529533/interface.c:2082:
< WARNING: Missing a blank line after declarations
< #2101: FILE: /tmp/f1-2529533/interface.c:2101:
< WARNING: Block comments use a trailing */ on a separate line
< #2115: FILE: /tmp/f1-2529533/interface.c:2115:
< WARNING: line over 80 characters
< #2131: FILE: /tmp/f1-2529533/interface.c:2131:
< WARNING: Too many leading tabs - consider code refactoring
< #2135: FILE: /tmp/f1-2529533/interface.c:2135:
< WARNING: line over 80 characters
< #2144: FILE: /tmp/f1-2529533/interface.c:2144:
< WARNING: Block comments use a trailing */ on a separate line
< #2171: FILE: /tmp/f1-2529533/interface.c:2171:
< WARNING: C99 // comments do not match recommendation
< #2232: FILE: /tmp/f1-2529533/interface.c:2232:
< WARNING: C99 // comments do not match recommendation
< #2233: FILE: /tmp/f1-2529533/interface.c:2233:
< WARNING: C99 // comments do not match recommendation
< #2234: FILE: /tmp/f1-2529533/interface.c:2234:
< WARNING: C99 // comments do not match recommendation
< #2235: FILE: /tmp/f1-2529533/interface.c:2235:
< WARNING: C99 // comments do not match recommendation
< #2236: FILE: /tmp/f1-2529533/interface.c:2236:
< WARNING: C99 // comments do not match recommendation
< #2237: FILE: /tmp/f1-2529533/interface.c:2237:
< WARNING: C99 // comments do not match recommendation
< #2238: FILE: /tmp/f1-2529533/interface.c:2238:
< WARNING: C99 // comments do not match recommendation
< #2239: FILE: /tmp/f1-2529533/interface.c:2239:
< WARNING: C99 // comments do not match recommendation
< #2241: FILE: /tmp/f1-2529533/interface.c:2241:
< WARNING: C99 // comments do not match recommendation
< #2242: FILE: /tmp/f1-2529533/interface.c:2242:
< WARNING: C99 // comments do not match recommendation
< #2243: FILE: /tmp/f1-2529533/interface.c:2243:
Report for zebra_vrf.c | 2 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #380: FILE: /tmp/f1-2529533/zebra_vrf.c:380:

NetDEF-CI · 2023-04-27T12:24:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11153/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11153/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1973:17: error: use of undeclared identifier 'AF_BRIDGE'
1 error generated.
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11153/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11153/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10517: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11153/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11153/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)
 1973 |   if (family == AF_BRIDGE)
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11153/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Successful on other platforms/tests

Debian 11 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 amd64 build
CentOS 7 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 20.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 ppc64le build
Redhat 9 amd64 build
Debian 10 amd64 build
Ubuntu 22.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11153/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11153/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1973:17: error: use of undeclared identifier 'AF_BRIDGE'
1 error generated.
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11153/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11153/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10517: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11153/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11153/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11153/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)
 1973 |   if (family == AF_BRIDGE)
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11153/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Report for if_netlink.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2212519/if_netlink.c:682:
< WARNING: void function return statements are not generally useful
< #739: FILE: /tmp/f1-2212519/if_netlink.c:739:
Report for interface.c | 46 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1549: FILE: /tmp/f1-2212519/interface.c:1549:
< WARNING: Block comments use a trailing */ on a separate line
< #1549: FILE: /tmp/f1-2212519/interface.c:1549:
< ERROR: do not use assignment in if condition
< #1555: FILE: /tmp/f1-2212519/interface.c:1555:
< WARNING: Block comments use a trailing */ on a separate line
< #2028: FILE: /tmp/f1-2212519/interface.c:2028:
< WARNING: Missing a blank line after declarations
< #2068: FILE: /tmp/f1-2212519/interface.c:2068:
< WARNING: Block comments use a trailing */ on a separate line
< #2082: FILE: /tmp/f1-2212519/interface.c:2082:
< WARNING: Missing a blank line after declarations
< #2101: FILE: /tmp/f1-2212519/interface.c:2101:
< WARNING: Block comments use a trailing */ on a separate line
< #2115: FILE: /tmp/f1-2212519/interface.c:2115:
< WARNING: line over 80 characters
< #2131: FILE: /tmp/f1-2212519/interface.c:2131:
< WARNING: Too many leading tabs - consider code refactoring
< #2135: FILE: /tmp/f1-2212519/interface.c:2135:
< WARNING: line over 80 characters
< #2144: FILE: /tmp/f1-2212519/interface.c:2144:
< WARNING: Block comments use a trailing */ on a separate line
< #2171: FILE: /tmp/f1-2212519/interface.c:2171:
< WARNING: C99 // comments do not match recommendation
< #2232: FILE: /tmp/f1-2212519/interface.c:2232:
< WARNING: C99 // comments do not match recommendation
< #2233: FILE: /tmp/f1-2212519/interface.c:2233:
< WARNING: C99 // comments do not match recommendation
< #2234: FILE: /tmp/f1-2212519/interface.c:2234:
< WARNING: C99 // comments do not match recommendation
< #2235: FILE: /tmp/f1-2212519/interface.c:2235:
< WARNING: C99 // comments do not match recommendation
< #2236: FILE: /tmp/f1-2212519/interface.c:2236:
< WARNING: C99 // comments do not match recommendation
< #2237: FILE: /tmp/f1-2212519/interface.c:2237:
< WARNING: C99 // comments do not match recommendation
< #2238: FILE: /tmp/f1-2212519/interface.c:2238:
< WARNING: C99 // comments do not match recommendation
< #2239: FILE: /tmp/f1-2212519/interface.c:2239:
< WARNING: C99 // comments do not match recommendation
< #2241: FILE: /tmp/f1-2212519/interface.c:2241:
< WARNING: C99 // comments do not match recommendation
< #2242: FILE: /tmp/f1-2212519/interface.c:2242:
< WARNING: C99 // comments do not match recommendation
< #2243: FILE: /tmp/f1-2212519/interface.c:2243:
Report for zebra_vrf.c | 2 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #380: FILE: /tmp/f1-2212519/zebra_vrf.c:380:

NetDEF-CI · 2023-04-27T12:57:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11155/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11155/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10517: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11155/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11155/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11155/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1973:17: error: use of undeclared identifier 'AF_BRIDGE'
1 error generated.
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11155/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)
 1973 |   if (family == AF_BRIDGE)
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11155/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Successful on other platforms/tests

Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 i386 build
CentOS 7 amd64 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 arm8 build
Redhat 8 amd64 build
Debian 9 amd64 build
Debian 10 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Redhat 9 amd64 build
Ubuntu 22.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11155/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.11155/frr-source/doc/user/nexthop_groups.rst
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function); did you mean 'AF_ROUTE'?
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10517: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11155/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11155/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11155/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1973:17: error: use of undeclared identifier 'AF_BRIDGE'
1 error generated.
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11155/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11155/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/interface.c: In function 'zebra_if_dplane_ifp_handling':
zebra/interface.c:1973:17: error: 'AF_BRIDGE' undeclared (first use in this function)
 1973 |   if (family == AF_BRIDGE)
zebra/interface.c:1973:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:10520: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11155/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Report for if_netlink.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2328967/if_netlink.c:682:
< WARNING: void function return statements are not generally useful
< #739: FILE: /tmp/f1-2328967/if_netlink.c:739:
Report for interface.c | 46 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1549: FILE: /tmp/f1-2328967/interface.c:1549:
< WARNING: Block comments use a trailing */ on a separate line
< #1549: FILE: /tmp/f1-2328967/interface.c:1549:
< ERROR: do not use assignment in if condition
< #1555: FILE: /tmp/f1-2328967/interface.c:1555:
< WARNING: Block comments use a trailing */ on a separate line
< #2028: FILE: /tmp/f1-2328967/interface.c:2028:
< WARNING: Missing a blank line after declarations
< #2068: FILE: /tmp/f1-2328967/interface.c:2068:
< WARNING: Block comments use a trailing */ on a separate line
< #2082: FILE: /tmp/f1-2328967/interface.c:2082:
< WARNING: Missing a blank line after declarations
< #2101: FILE: /tmp/f1-2328967/interface.c:2101:
< WARNING: Block comments use a trailing */ on a separate line
< #2115: FILE: /tmp/f1-2328967/interface.c:2115:
< WARNING: line over 80 characters
< #2131: FILE: /tmp/f1-2328967/interface.c:2131:
< WARNING: Too many leading tabs - consider code refactoring
< #2135: FILE: /tmp/f1-2328967/interface.c:2135:
< WARNING: line over 80 characters
< #2144: FILE: /tmp/f1-2328967/interface.c:2144:
< WARNING: Block comments use a trailing */ on a separate line
< #2171: FILE: /tmp/f1-2328967/interface.c:2171:
< WARNING: C99 // comments do not match recommendation
< #2232: FILE: /tmp/f1-2328967/interface.c:2232:
< WARNING: C99 // comments do not match recommendation
< #2233: FILE: /tmp/f1-2328967/interface.c:2233:
< WARNING: C99 // comments do not match recommendation
< #2234: FILE: /tmp/f1-2328967/interface.c:2234:
< WARNING: C99 // comments do not match recommendation
< #2235: FILE: /tmp/f1-2328967/interface.c:2235:
< WARNING: C99 // comments do not match recommendation
< #2236: FILE: /tmp/f1-2328967/interface.c:2236:
< WARNING: C99 // comments do not match recommendation
< #2237: FILE: /tmp/f1-2328967/interface.c:2237:
< WARNING: C99 // comments do not match recommendation
< #2238: FILE: /tmp/f1-2328967/interface.c:2238:
< WARNING: C99 // comments do not match recommendation
< #2239: FILE: /tmp/f1-2328967/interface.c:2239:
< WARNING: C99 // comments do not match recommendation
< #2241: FILE: /tmp/f1-2328967/interface.c:2241:
< WARNING: C99 // comments do not match recommendation
< #2242: FILE: /tmp/f1-2328967/interface.c:2242:
< WARNING: C99 // comments do not match recommendation
< #2243: FILE: /tmp/f1-2328967/interface.c:2243:
Report for zebra_vrf.c | 2 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #380: FILE: /tmp/f1-2328967/zebra_vrf.c:380:

NetDEF-CI · 2023-04-27T13:41:06Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function 'zebra_if_netconf_update_ctx':
./lib/zlog.h:109:20: error: format '%s' expects argument of type 'char *', but argument 3 has type 'ifindex_t {aka int}' [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro 'zlog_debug'
./lib/zlog.h:109:20: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
 1408 |    zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM8BUILD/config.status/config.status

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/REDHAT8/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/REDHAT8/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB10BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11160/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11160/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1408:41: error: format specifies type 'char *' but the argument has type 'ifindex_t' (aka 'int') [-Werror,-Wformat]
./lib/zlog.h:116:52: note: expanded from macro 'zlog_debug'
#define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:34: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug
 1408 |                         zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:34: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function 'zebra_if_netconf_update_ctx':
./lib/zlog.h:109:20: error: format '%s' expects argument of type 'char *', but argument 3 has type 'ifindex_t' {aka 'int'} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
zebra/interface.c:1408:4: note: in expansion of macro 'zlog_debug'
 1408 |    zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:20: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
zebra/interface.c:1408:4: note: in expansion of macro 'zlog_debug'

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
 1408 |    zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/RH9BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:34: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug
 1408 |                         zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:34: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Successful on other platforms/tests

CentOS 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function 'zebra_if_netconf_update_ctx':
./lib/zlog.h:109:20: error: format '%s' expects argument of type 'char *', but argument 3 has type 'ifindex_t {aka int}' [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro 'zlog_debug'
./lib/zlog.h:109:20: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
 1408 |    zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18ARM8BUILD/config.status/config.status

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/REDHAT8/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/REDHAT8/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/DEB10BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11160/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11160/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
zebra/interface.c:1408:41: error: format specifies type 'char *' but the argument has type 'ifindex_t' (aka 'int') [-Werror,-Wformat]
./lib/zlog.h:116:52: note: expanded from macro 'zlog_debug'
#define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:34: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug
 1408 |                         zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:34: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function 'zebra_if_netconf_update_ctx':
./lib/zlog.h:109:20: error: format '%s' expects argument of type 'char *', but argument 3 has type 'ifindex_t' {aka 'int'} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
zebra/interface.c:1408:4: note: in expansion of macro 'zlog_debug'
 1408 |    zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:20: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro '_zlog_ecref'
zebra/interface.c:1408:4: note: in expansion of macro 'zlog_debug'

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
 1408 |    zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/RH9BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:34: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug
 1408 |                         zlog_debug("%s: Can't find ifp(%u)", ifindex);
./lib/zlog.h:109:34: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
zebra/interface.c:1408:25: note: in expansion of macro zlog_debug

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11160/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
zebra/interface.c: In function zebra_if_netconf_update_ctx:
./lib/zlog.h:109:20: error: format %s expects argument of type char *, but argument 3 has type ifindex_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/interface.c:1408:4: note: in expansion of macro zlog_debug
./lib/zlog.h:109:20: error: format %u expects a matching unsigned int argument [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2567903/if_netlink.c:682:
Report for interface.c | 14 issues
===============================================
< ERROR: do not use assignment in if condition
< #1564: FILE: /tmp/f1-2567903/interface.c:1564:
< WARNING: Block comments use a trailing */ on a separate line
< #2100: FILE: /tmp/f1-2567903/interface.c:2100:
< WARNING: Missing a blank line after declarations
< #2119: FILE: /tmp/f1-2567903/interface.c:2119:
< WARNING: line over 80 characters
< #2152: FILE: /tmp/f1-2567903/interface.c:2152:
< WARNING: Too many leading tabs - consider code refactoring
< #2156: FILE: /tmp/f1-2567903/interface.c:2156:
< WARNING: line over 80 characters
< #2165: FILE: /tmp/f1-2567903/interface.c:2165:
< WARNING: Block comments use a trailing */ on a separate line
< #2192: FILE: /tmp/f1-2567903/interface.c:2192:

NetDEF-CI · 2023-04-27T13:51:23Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9409: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11158/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11158/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11158/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.11158/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/local/bin/ld: /usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9412: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11158/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Successful on other platforms/tests

Ubuntu 16.04 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 arm8 build
Debian 11 amd64 build
Redhat 8 amd64 build
Debian 10 amd64 build
Ubuntu 16.04 arm7 build
Ubuntu 20.04 amd64 build
Ubuntu 22.04 amd64 build
CentOS 7 amd64 build
Debian 9 amd64 build
Redhat 9 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 ppc64le build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9409: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11158/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11158/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11158/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_mpls_openbsd.c:233:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
zebra/zebra_mpls_openbsd.c:446:10: error: enumeration value 'DPLANE_OP_STARTUP_STAGE' not handled in switch [-Werror,-Wswitch]
2 errors generated.
gmake[1]: *** [Makefile:10520: zebra/zebra_mpls_openbsd.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.11158/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11158/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/local/bin/ld: /usr/home/ci/cibuild.11158/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9412: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11158/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Report for if_netlink.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2522550/if_netlink.c:682:
< WARNING: void function return statements are not generally useful
< #739: FILE: /tmp/f1-2522550/if_netlink.c:739:
Report for interface.c | 46 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1549: FILE: /tmp/f1-2522550/interface.c:1549:
< WARNING: Block comments use a trailing */ on a separate line
< #1549: FILE: /tmp/f1-2522550/interface.c:1549:
< ERROR: do not use assignment in if condition
< #1555: FILE: /tmp/f1-2522550/interface.c:1555:
< WARNING: Block comments use a trailing */ on a separate line
< #2034: FILE: /tmp/f1-2522550/interface.c:2034:
< WARNING: Missing a blank line after declarations
< #2074: FILE: /tmp/f1-2522550/interface.c:2074:
< WARNING: Block comments use a trailing */ on a separate line
< #2088: FILE: /tmp/f1-2522550/interface.c:2088:
< WARNING: Missing a blank line after declarations
< #2107: FILE: /tmp/f1-2522550/interface.c:2107:
< WARNING: Block comments use a trailing */ on a separate line
< #2121: FILE: /tmp/f1-2522550/interface.c:2121:
< WARNING: line over 80 characters
< #2137: FILE: /tmp/f1-2522550/interface.c:2137:
< WARNING: Too many leading tabs - consider code refactoring
< #2141: FILE: /tmp/f1-2522550/interface.c:2141:
< WARNING: line over 80 characters
< #2150: FILE: /tmp/f1-2522550/interface.c:2150:
< WARNING: Block comments use a trailing */ on a separate line
< #2177: FILE: /tmp/f1-2522550/interface.c:2177:
< WARNING: C99 // comments do not match recommendation
< #2238: FILE: /tmp/f1-2522550/interface.c:2238:
< WARNING: C99 // comments do not match recommendation
< #2239: FILE: /tmp/f1-2522550/interface.c:2239:
< WARNING: C99 // comments do not match recommendation
< #2240: FILE: /tmp/f1-2522550/interface.c:2240:
< WARNING: C99 // comments do not match recommendation
< #2241: FILE: /tmp/f1-2522550/interface.c:2241:
< WARNING: C99 // comments do not match recommendation
< #2242: FILE: /tmp/f1-2522550/interface.c:2242:
< WARNING: C99 // comments do not match recommendation
< #2243: FILE: /tmp/f1-2522550/interface.c:2243:
< WARNING: C99 // comments do not match recommendation
< #2244: FILE: /tmp/f1-2522550/interface.c:2244:
< WARNING: C99 // comments do not match recommendation
< #2245: FILE: /tmp/f1-2522550/interface.c:2245:
< WARNING: C99 // comments do not match recommendation
< #2247: FILE: /tmp/f1-2522550/interface.c:2247:
< WARNING: C99 // comments do not match recommendation
< #2248: FILE: /tmp/f1-2522550/interface.c:2248:
< WARNING: C99 // comments do not match recommendation
< #2249: FILE: /tmp/f1-2522550/interface.c:2249:
Report for zebra_vrf.c | 2 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #380: FILE: /tmp/f1-2522550/zebra_vrf.c:380:

NetDEF-CI · 2023-04-27T14:23:16Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9409: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11162/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/local/bin/ld: /usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9412: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11162/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11162/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11162/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
ld: error: undefined symbol: interface_list_tunneldump
>>> referenced by zebra_ns.c:120 (zebra/zebra_ns.c:120)
>>>               zebra/zebra_ns.o:(zebra_ns_startup_continue)
ld: error: undefined symbol: interface_list_second
>>> referenced by zebra_ns.c:123 (zebra/zebra_ns.c:123)
>>>               zebra/zebra_ns.o:(zebra_ns_startup_continue)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Successful on other platforms/tests

Ubuntu 18.04 ppc64le build
Ubuntu 22.04 amd64 build
Debian 11 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 18.04 arm8 build
Redhat 9 amd64 build
Debian 10 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 20.04 amd64 build
Ubuntu 16.04 amd64 build
CentOS 7 amd64 build
Redhat 8 amd64 build
Debian 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9409: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11162/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6403: all] Error 2

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:123: undefined reference to `interface_list_second'
/usr/local/bin/ld: /usr/home/ci/cibuild.11162/frr-source/zebra/zebra_ns.c:120: undefined reference to `interface_list_tunneldump'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:9412: zebra/zebra] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.11162/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6406: all] Error 2

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-11162/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.11162/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.11162/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
ld: error: undefined symbol: interface_list_tunneldump
>>> referenced by zebra_ns.c:120 (zebra/zebra_ns.c:120)
>>>               zebra/zebra_ns.o:(zebra_ns_startup_continue)
ld: error: undefined symbol: interface_list_second
>>> referenced by zebra_ns.c:123 (zebra/zebra_ns.c:123)
>>>               zebra/zebra_ns.o:(zebra_ns_startup_continue)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2730638/if_netlink.c:682:
Report for interface.c | 14 issues
===============================================
< ERROR: do not use assignment in if condition
< #1564: FILE: /tmp/f1-2730638/interface.c:1564:
< WARNING: Block comments use a trailing */ on a separate line
< #2100: FILE: /tmp/f1-2730638/interface.c:2100:
< WARNING: Missing a blank line after declarations
< #2119: FILE: /tmp/f1-2730638/interface.c:2119:
< WARNING: line over 80 characters
< #2152: FILE: /tmp/f1-2730638/interface.c:2152:
< WARNING: Too many leading tabs - consider code refactoring
< #2156: FILE: /tmp/f1-2730638/interface.c:2156:
< WARNING: line over 80 characters
< #2165: FILE: /tmp/f1-2730638/interface.c:2165:
< WARNING: Block comments use a trailing */ on a separate line
< #2192: FILE: /tmp/f1-2730638/interface.c:2192:

NetDEF-CI · 2023-04-27T14:28:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11163/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

Successful on other platforms/tests

Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 22.04 amd64 build
FreeBSD 12 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 18.04 arm8 build
Debian 10 amd64 build
Redhat 9 amd64 build
Debian 11 amd64 build
FreeBSD 11 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 16.04 amd64 build
OpenBSD 7 amd64 build
CentOS 7 amd64 build
Redhat 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2749608/if_netlink.c:682:
Report for interface.c | 14 issues
===============================================
< ERROR: do not use assignment in if condition
< #1564: FILE: /tmp/f1-2749608/interface.c:1564:
< WARNING: Block comments use a trailing */ on a separate line
< #2100: FILE: /tmp/f1-2749608/interface.c:2100:
< WARNING: Missing a blank line after declarations
< #2119: FILE: /tmp/f1-2749608/interface.c:2119:
< WARNING: line over 80 characters
< #2152: FILE: /tmp/f1-2749608/interface.c:2152:
< WARNING: Too many leading tabs - consider code refactoring
< #2156: FILE: /tmp/f1-2749608/interface.c:2156:
< WARNING: line over 80 characters
< #2165: FILE: /tmp/f1-2749608/interface.c:2165:
< WARNING: Block comments use a trailing */ on a separate line
< #2192: FILE: /tmp/f1-2749608/interface.c:2192:
Report for kernel_socket.c | 4 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1474: FILE: /tmp/f1-2749608/kernel_socket.c:1474:
< WARNING: void function return statements are not generally useful
< #1479: FILE: /tmp/f1-2749608/kernel_socket.c:1479:

NetDEF-CI · 2023-04-27T15:11:06Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11165/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

Successful on other platforms/tests

Ubuntu 22.04 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 20.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
FreeBSD 11 amd64 build
Ubuntu 18.04 arm7 build
CentOS 7 amd64 build
Debian 11 amd64 build
Redhat 9 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
FreeBSD 12 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build
OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

<stdin>:8: trailing whitespace.
debug pathd pcep 
warning: 1 line adds whitespace errors.
Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-2978943/if_netlink.c:682:
Report for interface.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2155: FILE: /tmp/f1-2978943/interface.c:2155:
< WARNING: Too many leading tabs - consider code refactoring
< #2159: FILE: /tmp/f1-2978943/interface.c:2159:
< WARNING: line over 80 characters
< #2168: FILE: /tmp/f1-2978943/interface.c:2168:
Report for pathd.conf | 2 issues
===============================================
< ERROR: trailing whitespace
< #3: FILE: /tmp/f1-2978943/pathd.conf:3:

NetDEF-CI · 2023-04-27T15:31:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11166/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

Successful on other platforms/tests

Ubuntu 20.04 amd64 build
Ubuntu 22.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
FreeBSD 11 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 i386 build
CentOS 7 amd64 build
Ubuntu 18.04 amd64 build
Redhat 9 amd64 build
Debian 11 amd64 build
OpenBSD 7 amd64 build
Ubuntu 16.04 amd64 build
FreeBSD 12 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-3072131/if_netlink.c:682:
Report for interface.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2155: FILE: /tmp/f1-3072131/interface.c:2155:
< WARNING: Too many leading tabs - consider code refactoring
< #2159: FILE: /tmp/f1-3072131/interface.c:2159:
< WARNING: line over 80 characters
< #2168: FILE: /tmp/f1-3072131/interface.c:2168:

donaldsharp · 2023-04-27T16:41:31Z

ci:rerun

NetDEF-CI · 2023-04-27T19:46:03Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11170/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11170/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Addresssanitizer topotests part 8
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11170/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-3648475/if_netlink.c:682:
Report for interface.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2155: FILE: /tmp/f1-3648475/interface.c:2155:
< WARNING: Too many leading tabs - consider code refactoring
< #2159: FILE: /tmp/f1-3648475/interface.c:2159:
< WARNING: line over 80 characters
< #2168: FILE: /tmp/f1-3648475/interface.c:2168:

CLANG Static Analyzer Summary

Github Pull Request 13396, comparing to Git base SHA 34a8441
Base image data for Git 34a8441 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-11170/artifact/shared/static_analysis/index.html

NetDEF-CI · 2023-04-27T21:06:24Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11174/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #682: FILE: /tmp/f1-4025950/if_netlink.c:682:
Report for interface.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2161: FILE: /tmp/f1-4025950/interface.c:2161:
< WARNING: Too many leading tabs - consider code refactoring
< #2165: FILE: /tmp/f1-4025950/interface.c:2165:
< WARNING: line over 80 characters
< #2174: FILE: /tmp/f1-4025950/interface.c:2174:

github-actions · 2023-05-02T14:54:11Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

riw777

looks good ... waiting on comments from others

github-actions · 2023-06-23T08:09:48Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Rename the vrf_lookup_by_id function to zebra_vrf_lookup_by_id and move to zebra_vrf.c where it nominally belongs, as that we need zebra specific data to find this vrf_id and as such it does not belong in vrf.c Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Since we are moving some code handling out of the dataplane and into zebra proper, lets move the protodown r bit as well. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

There is no need for this functionality and it is not used. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Function was not using the add variable. Remove it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Turns out FRR has 2 functions one specifically for startup and one for normal day to day operations. There were only a couple of minor differences from what I could tell, and where they were different the after startup functionality should have been updated too. I cannot figure out why we have 2. Non-startup handling of bonds appears to be incorrect so let's fix that. Additionally the speed was not properly being set in non-startup situations. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

1) Add a bunch of get/set functions and associated data structure in zebra_dplane to allow the setting and retrieval of interface netlink data up into the master pthread. 2) Add a bit of code to breakup startup into stages. This is because FRR currently has a mix of dplane and non dplane interactions and the code needs to be paused before continuing on. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

a) Move the reads of link and address information into the dplane b) Move the startup read of data into the dplane as well. c) Break up startup reading of the linux kernel data into multiple phases. As that we have implied ordering of data that must be read first and if the dplane has taken over some data reading then we must delay initial read-in of other data. Fixes: FRRouting#13288 Signed-off-by: Donald Sharp <sharpd@nvidia.com>

NetDEF-CI · 2023-07-05T18:55:03Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12761/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for interface.c | 2 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2171: FILE: /tmp/f1-881666/interface.c:2171:

NetDEF-CI · 2023-07-05T19:48:55Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12762/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12762/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 20.04 deb pkg check
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12762/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12762/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12762/artifact/TOPO3DEB10AMD64/TopotestDetails/

Report for interface.c | 2 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2171: FILE: /tmp/f1-1226335/interface.c:2171:

donaldsharp · 2023-07-05T23:03:10Z

ci:rerun

NetDEF-CI · 2023-07-06T01:41:44Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12770/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12770/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12770/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12770/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12770/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12770/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12770/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Report for interface.c | 2 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2171: FILE: /tmp/f1-3407754/interface.c:2171:

riw777 · 2023-07-06T03:02:30Z

The CI failure shouldn't be related to these code changes ... let's rerun

ci:rerun

NetDEF-CI · 2023-07-06T05:57:04Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12772/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for interface.c | 2 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2171: FILE: /tmp/f1-135036/interface.c:2171:

Why I did it Upgrading FRR 8.5.1 to include latest fixes. New patches that were added: Patch FRR Pull request Issue fixed 0012-zebra-Rename-vrf_lookup_by_tableid-to-zebra_vrf_look.patch FRRouting/frr#13396 #14866 0013-zebra-Move-protodown_r_bit-to-a-better-spot.patch FRRouting/frr#13396 #14866 0014-zebra-Remove-unused-dplane_intf_delete.patch FRRouting/frr#13396 #14866 0015-zebra-Remove-unused-add-variable.patch FRRouting/frr#13396 #14866 0016-zebra-Remove-duplicate-function-for-netlink-interfac.patch FRRouting/frr#13396 #14866 0017-zebra-Add-code-to-get-set-interface-to-pass-up-from-.patch FRRouting/frr#13396 #14866 0018-zebra-Use-zebra-dplane-for-RTM-link-and-addr.patch FRRouting/frr#13396 #14866 0019-zebra-Abstract-dplane_ctx_route_init-to-init-route-w.patch FRRouting/frr#13757 FRRouting/frr#13754 00020-zebra-Fix-crash-when-dplane_fpm_nl-fails-to-process-.patch FRRouting/frr#13757 FRRouting/frr#13754 Removed patches: Patch Upstream FRR commit that is present in 8.5.1 0001-Add-support-of-bgp-tcp-DSCP-value.patch FRRouting/frr@425bd64 0010-zebra-Note-when-the-netlink-DUMP-command-is-interrup.patch FRRouting/frr@2f71996 0011-bgpd-enhanced-capability-is-always-turned-on-for-int.patch FRRouting/frr@8e89adc 0012-Ensure-ospf_apiclient_lsa_originate-cannot-accidently-write-into-stack.patch FRRouting/frr@d2aeac3 , FRRouting/frr@49efc80, FRRouting/frr@ff6db10 0013-zebra-fix-dplane-fpm-nl-to-allow-for-fast-configuration.patch FRRouting/frr@551fa8c 0014-bgpd-Allow-network-XXX-to-work-with-bgp-suppress-fib.patch FRRouting/frr@4801fc4 0015-zebra-Return-statements-do-not-use-paranthesis.patch FRRouting/frr@871a16c 0016-zebra-Add-zrouter.asic_notification_nexthop_control.patch FRRouting/frr@06525c4 0017-zebra-Re-arrange-fpm_read-to-reduce-code-duplication.patch FRRouting/frr@7d83e13 0018-zebra-Add-dplane_ctx_get-set_flags.patch FRRouting/frr@10388e9 0019-zebra-Rearrange-dplane_ctx_route_init.patch FRRouting/frr@f935122 0020-zebra-Add-ctx-to-netlink-message-parsing.patch FRRouting/frr@45f0a10 0021-zebra-Read-from-the-dplane_fpm_nl-a-route-update.patch FRRouting/frr@a0e1173 0022-zebra-Fix-code-because-missing-backport.patch FRRouting/frr@07fd1f7 0024-zebra-continue-fpm-read-when-we-decide-a-netlink-message-is-not-needed.patch FRRouting/frr@c0275ab 0025-zebra-Send-nht-resolved-entry-up-to-concerned-protoc.patch FRRouting/frr@8ce0e51 0027-bgpd-Ensure-FRR-has-enough-data-to-read-in-peek_for_as4_capability-and-bgp_open_option_parse.patch FRRouting/frr@3e46b43 0028-bgpd-Ensure-that-bgp-open-message-stream-has-enough-data-to-read.patch FRRouting/frr@766eec1 Realigned patches: Old Patch New patch 0002-Reduce-severity-of-Vty-connected-from-message.patch 0001-Reduce-severity-of-Vty-connected-from-message.patch 0004-Allow-BGP-attr-NEXT_HOP-to-be-0.0.0.0-due-to-allevia.patch 0002-Allow-BGP-attr-NEXT_HOP-to-be-0.0.0.0-due-to-allevia.patch 0005-nexthops-compare-vrf-only-if-ip-type.patch 0003-nexthops-compare-vrf-only-if-ip-type.patch 0006-frr-remove-frr-log-outchannel-to-var-log-frr.log.patch 0004-frr-remove-frr-log-outchannel-to-var-log-frr.log.patch 0007-Add-support-of-bgp-l3vni-evpn.patch 0005-Add-support-of-bgp-l3vni-evpn.patch 0008-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch 0006-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch 0009-ignore-route-from-default-table.patch 0007-ignore-route-from-default-table.patch 0009-ignore-route-from-default-table.patch 0007-ignore-route-from-default-table.patch 0023-Use-vrf_id-for-vrf-not-tabled_id.patch 0008-Use-vrf_id-for-vrf-not-tabled_id.patch 0026-bgpd-Ensure-suppress-fib-pending-works-with-network-.patch 0009-bgpd-Ensure-suppress-fib-pending-works-with-network-.patch 0029-bgpd-Change-log-level-for-graceful-restart-events.patch 0010-bgpd-Change-log-level-for-graceful-restart-events.patch 0030-zebra-Static-routes-async-notification-do-not-need-t.patch 0011-zebra-Static-routes-async-notification-do-not-need-t.patch How I did it Upgrade FRR submodule. Align the patches. Integrate new patches to fix issues. How to verify it Run sonic-mgmt regression to verify

Why I did it Upgrading FRR 8.5.1 to include latest fixes. New patches that were added: Patch FRR Pull request Issue fixed 0012-zebra-Rename-vrf_lookup_by_tableid-to-zebra_vrf_look.patch FRRouting/frr#13396 sonic-net#14866 0013-zebra-Move-protodown_r_bit-to-a-better-spot.patch FRRouting/frr#13396 sonic-net#14866 0014-zebra-Remove-unused-dplane_intf_delete.patch FRRouting/frr#13396 sonic-net#14866 0015-zebra-Remove-unused-add-variable.patch FRRouting/frr#13396 sonic-net#14866 0016-zebra-Remove-duplicate-function-for-netlink-interfac.patch FRRouting/frr#13396 sonic-net#14866 0017-zebra-Add-code-to-get-set-interface-to-pass-up-from-.patch FRRouting/frr#13396 sonic-net#14866 0018-zebra-Use-zebra-dplane-for-RTM-link-and-addr.patch FRRouting/frr#13396 sonic-net#14866 0019-zebra-Abstract-dplane_ctx_route_init-to-init-route-w.patch FRRouting/frr#13757 FRRouting/frr#13754 00020-zebra-Fix-crash-when-dplane_fpm_nl-fails-to-process-.patch FRRouting/frr#13757 FRRouting/frr#13754 Removed patches: Patch Upstream FRR commit that is present in 8.5.1 0001-Add-support-of-bgp-tcp-DSCP-value.patch FRRouting/frr@425bd64 0010-zebra-Note-when-the-netlink-DUMP-command-is-interrup.patch FRRouting/frr@2f71996 0011-bgpd-enhanced-capability-is-always-turned-on-for-int.patch FRRouting/frr@8e89adc 0012-Ensure-ospf_apiclient_lsa_originate-cannot-accidently-write-into-stack.patch FRRouting/frr@d2aeac3 , FRRouting/frr@49efc80, FRRouting/frr@ff6db10 0013-zebra-fix-dplane-fpm-nl-to-allow-for-fast-configuration.patch FRRouting/frr@551fa8c 0014-bgpd-Allow-network-XXX-to-work-with-bgp-suppress-fib.patch FRRouting/frr@4801fc4 0015-zebra-Return-statements-do-not-use-paranthesis.patch FRRouting/frr@871a16c 0016-zebra-Add-zrouter.asic_notification_nexthop_control.patch FRRouting/frr@06525c4 0017-zebra-Re-arrange-fpm_read-to-reduce-code-duplication.patch FRRouting/frr@7d83e13 0018-zebra-Add-dplane_ctx_get-set_flags.patch FRRouting/frr@10388e9 0019-zebra-Rearrange-dplane_ctx_route_init.patch FRRouting/frr@f935122 0020-zebra-Add-ctx-to-netlink-message-parsing.patch FRRouting/frr@45f0a10 0021-zebra-Read-from-the-dplane_fpm_nl-a-route-update.patch FRRouting/frr@a0e1173 0022-zebra-Fix-code-because-missing-backport.patch FRRouting/frr@07fd1f7 0024-zebra-continue-fpm-read-when-we-decide-a-netlink-message-is-not-needed.patch FRRouting/frr@c0275ab 0025-zebra-Send-nht-resolved-entry-up-to-concerned-protoc.patch FRRouting/frr@8ce0e51 0027-bgpd-Ensure-FRR-has-enough-data-to-read-in-peek_for_as4_capability-and-bgp_open_option_parse.patch FRRouting/frr@3e46b43 0028-bgpd-Ensure-that-bgp-open-message-stream-has-enough-data-to-read.patch FRRouting/frr@766eec1 Realigned patches: Old Patch New patch 0002-Reduce-severity-of-Vty-connected-from-message.patch 0001-Reduce-severity-of-Vty-connected-from-message.patch 0004-Allow-BGP-attr-NEXT_HOP-to-be-0.0.0.0-due-to-allevia.patch 0002-Allow-BGP-attr-NEXT_HOP-to-be-0.0.0.0-due-to-allevia.patch 0005-nexthops-compare-vrf-only-if-ip-type.patch 0003-nexthops-compare-vrf-only-if-ip-type.patch 0006-frr-remove-frr-log-outchannel-to-var-log-frr.log.patch 0004-frr-remove-frr-log-outchannel-to-var-log-frr.log.patch 0007-Add-support-of-bgp-l3vni-evpn.patch 0005-Add-support-of-bgp-l3vni-evpn.patch 0008-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch 0006-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch 0009-ignore-route-from-default-table.patch 0007-ignore-route-from-default-table.patch 0009-ignore-route-from-default-table.patch 0007-ignore-route-from-default-table.patch 0023-Use-vrf_id-for-vrf-not-tabled_id.patch 0008-Use-vrf_id-for-vrf-not-tabled_id.patch 0026-bgpd-Ensure-suppress-fib-pending-works-with-network-.patch 0009-bgpd-Ensure-suppress-fib-pending-works-with-network-.patch 0029-bgpd-Change-log-level-for-graceful-restart-events.patch 0010-bgpd-Change-log-level-for-graceful-restart-events.patch 0030-zebra-Static-routes-async-notification-do-not-need-t.patch 0011-zebra-Static-routes-async-notification-do-not-need-t.patch How I did it Upgrade FRR submodule. Align the patches. Integrate new patches to fix issues. How to verify it Run sonic-mgmt regression to verify

Why I did it Upgrading FRR 8.5.4 to include latest fixes. Work item tracking Microsoft ADO (number only): How I did it New patches that were added: Patch FRR Pull request Issue fixed 0024-lib-use-snmp-s-large-fd-sets-for-agentx.patch FRRouting/frr#13396 FRRouting/frr#14143 0025-bgp-community-memory-leak-fix.patch FRRouting/frr#15466 FRRouting/frr#15459 0026-bgp-fib-suppress-announce-fix.patch FRRouting/frr#15634 FRRouting/frr#15626 0027-lib-Do-not-convert-EVPN-prefixes-into-IPv4-IPv6-if-n.patch FRRouting/frr#15418 FRRouting/frr#14419 Removed patches: Patch Upstream FRR commit that is present in 8.5.4 0019-zebra-Abstract-dplane_ctx_route_init-to-init-route-w.patch FRRouting/frr@3f01977 0020-zebra-Fix-crash-when-dplane_fpm_nl-fails-to-process-.patch FRRouting/frr@fe5f624 0022-bgpd-Don-t-read-the-first-byte-of-ORF-header-if-we-a.patch FRRouting/frr@3515178 0023-bgpd-Make-sure-we-have-enough-data-to-read-two-bytes.patch FRRouting/frr@460ee93 0024-bgpd-Do-not-process-NLRIs-if-the-attribute-length-is.patch FRRouting/frr@f291f1e 0025-bgpd-Use-treat-as-withdraw-for-tunnel-encapsulation-.patch FRRouting/frr@8a4a88c 0026-zebra-Add-encap-type-when-building-packet-for-FPM.patch FRRouting/frr@f0f7b28 0028-bgpd-Check-mandatory-attributes-more-carefully-for-U.patch FRRouting/frr@21418d6 0029-bgpd-Handle-MP_REACH_NLRI-malformed-packets-with-ses.patch FRRouting/frr@30b5c2a 0030-bgpd-Treat-EOR-as-withdrawn-to-avoid-unwanted-handli.patch FRRouting/frr@01f232c 0031-bgpd-Ignore-handling-NLRIs-if-we-received-MP_UNREACH.patch FRRouting/frr@a0c4ec2 0032-zebra-Fix-fpm-multipath-encap-addition.patch FRRouting/frr@10a9a5f Realigned patches: Old Patch New patch 0005-Add-support-of-bgp-l3vni-evpn.patch 0005-Add-support-of-bgp-l3vni-evpn.patch 0021-zebra-remove-duplicated-nexthops-when-sending-fpm-msg.patch 0019-zebra-remove-duplicated-nexthops-when-sending-fpm-msg.patch 0027-zebra-Fix-non-notification-of-better-admin-won.patch 0020-zebra-Fix-non-notification-of-better-admin-won.patch Disable-ipv6-src-address-test-in-pceplib.patch 0021-Disable-ipv6-src-address-test-in-pceplib.patch cross-compile-changes.patch 0022-cross-compile-changes.patch 0033-zebra-The-dplane_fpm_nl-return-path-leaks-memory.patch 0023-zebra-The-dplane_fpm_nl-return-path-leaks-memory.patch How to verify it Running sonic-mgmt test suite.

Trigger: Zebra core seen when we convert l2vni to l3vni and back BackTrace: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(_zlog_assert_failed+0xe9) [0x7f4af96989d9] /usr/lib/frr/zebra(zebra_vxlan_if_vni_up+0x250) [0x5561022ae030] /usr/lib/frr/zebra(netlink_vlan_change+0x2f4) [0x5561021fd354] /usr/lib/frr/zebra(netlink_parse_info+0xff) [0x55610220d37f] /usr/lib/frr/zebra(+0xc264a) [0x55610220d64a] /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(thread_call+0x7d) [0x7f4af967e96d] /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(frr_run+0xe8) [0x7f4af9637588] /usr/lib/frr/zebra(main+0x402) [0x5561021f4d32] /lib/x86_64-linux-gnu/libc.so.6(+0x2724a) [0x7f4af932624a] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85) [0x7f4af9326305] /usr/lib/frr/zebra(_start+0x21) [0x5561021f72f1] Root Cause: In working case, - We get a RTM_NEWLINK whose ctx is enqueued by zebra dplane and dequeued by zebra main and processed i.e. (102000 is deleted from vxlan99) before we handle RTM_NEWVLAN. - So in handling of NEWVLAN (vxlan99) we bail out since find with vlan id 703 does not exist. root@leaf2:mgmt:/var/log/frr# cat ~/raja_logs/working/nocras.log | grep "RTM_NEWLINK\|QUEUED\|vxlan99\|in thread" 2024/07/18 23:09:33.741105 ZEBRA: [KMXEB-K771Y] netlink_parse_info: netlink-dp-in (NS 0) type RTM_NEWLINK(16), len=616, seq=0, pid=0 2024/07/18 23:09:33.744061 ZEBRA: [K8FXY-V65ZJ] Intf dplane ctx 0x7f2244000cf0, op INTF_INSTALL, ifindex (65), result QUEUED 2024/07/18 23:09:33.767240 ZEBRA: [KMXEB-K771Y] netlink_parse_info: netlink-dp-in (NS 0) type RTM_NEWLINK(16), len=508, seq=0, pid=0 2024/07/18 23:09:33.767380 ZEBRA: [K8FXY-V65ZJ] Intf dplane ctx 0x7f2244000cf0, op INTF_INSTALL, ifindex (73), result QUEUED 2024/07/18 23:09:33.767389 ZEBRA: [NVFT0-HS1EX] INTF_INSTALL for vxlan99(73) 2024/07/18 23:09:33.767404 ZEBRA: [TQR2A-H2RFY] Vlan-Vni(1186:1186-6000002:6000002) update for VxLAN IF vxlan99(73) 2024/07/18 23:09:33.767422 ZEBRA: [TP4VP-XZ627] Del L2-VNI 102000 intf vxlan99(73) 2024/07/18 23:09:33.767858 ZEBRA: [QYXB9-6RNNK] RTM_NEWVLAN bridge IF vxlan99 NS 0 2024/07/18 23:09:33.767866 ZEBRA: [KKZGZ-8PCDW] Cannot find VNI for VID (703) IF vxlan99 for vlan state update >>>>BAIL OUT In failure case, - The NEWVLAN is received first even before processing RTM_NEWLINK. - Since the vxlan id 102000 is not removed from the vxlan99, the find with vlan id 703 returns the 102000 one and we invoke zebra_vxlan_if_vni_up where the interfaces don't match and assert. root@leaf2:mgmt:/var/log/frr# cat ~/raja_logs/noworking/crash.log | grep "RTM_NEWLINK\|QUEUED\|vxlan99\|in thread" 2024/07/18 22:26:43.829370 ZEBRA: [KMXEB-K771Y] netlink_parse_info: netlink-dp-in (NS 0) type RTM_NEWLINK(16), len=616, seq=0, pid=0 2024/07/18 22:26:43.829646 ZEBRA: [K8FXY-V65ZJ] Intf dplane ctx 0x7fe07c026d30, op INTF_INSTALL, ifindex (65), result QUEUED 2024/07/18 22:26:43.853930 ZEBRA: [QYXB9-6RNNK] RTM_NEWVLAN bridge IF vxlan99 NS 0 2024/07/18 22:26:43.853949 ZEBRA: [K61WJ-XQQ3X] Intf vxlan99(73) L2-VNI 102000 is UP >>> VLAN PROCESSED BEFORE INTF EVENT 2024/07/18 22:26:43.853951 ZEBRA: [SPV50-BX2RP] RAJA zevpn_vxlanif vxlan48 and ifp vxlan99 2024/07/18 22:26:43.854005 ZEBRA: [KMXEB-K771Y] netlink_parse_info: netlink-dp-in (NS 0) type RTM_NEWLINK(16), len=508, seq=0, pid=0 2024/07/18 22:26:43.854241 ZEBRA: [KMXEB-K771Y] netlink_parse_info: netlink-dp-in (NS 0) type RTM_NEWLINK(16), len=516, seq=0, pid=0 2024/07/18 22:26:43.854251 ZEBRA: [KMXEB-K771Y] netlink_parse_info: netlink-dp-in (NS 0) type RTM_NEWLINK(16), len=544, seq=0, pid=0 ZEBRA: in thread kernel_read scheduled from zebra/kernel_netlink.c:505 kernel_read() Fix: Similar to FRRouting#13396, where link change handling was offloaded to dplane, same is being done for vlan events. Note: Prior to this change, zebra main thread was interested in the RTNLGRP_BRVLAN. So all the kernel events pertaining to vlan was handled by zebra main. With this change change as well the handling of vlan events is still with Zebra main. However we offload it via Dplane thread. Ticket :#3878175 Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>

frrbot bot added bugfix zebra labels Apr 27, 2023

github-actions bot added master size/XXL labels Apr 27, 2023

donaldsharp force-pushed the interface_is_interface branch from 4180ba4 to dc66a85 Compare April 27, 2023 03:51

donaldsharp force-pushed the interface_is_interface branch from dc66a85 to 90187b3 Compare April 27, 2023 11:50

donaldsharp force-pushed the interface_is_interface branch 2 times, most recently from 6412a41 to dbebf9c Compare April 27, 2023 13:26

donaldsharp force-pushed the interface_is_interface branch 2 times, most recently from c07ad85 to 4ecf8ae Compare April 27, 2023 13:55

donaldsharp force-pushed the interface_is_interface branch 2 times, most recently from d08e340 to d0c5373 Compare April 27, 2023 14:58

donaldsharp force-pushed the interface_is_interface branch from d0c5373 to c328c2b Compare April 27, 2023 18:00

github-actions bot added the conflicts label May 2, 2023

donaldsharp force-pushed the interface_is_interface branch from c328c2b to e9309cc Compare May 10, 2023 17:57

riw777 approved these changes Jun 21, 2023

View reviewed changes

github-actions bot added the conflicts label Jun 23, 2023

donaldsharp added 4 commits July 5, 2023 11:49

zebra: Move protodown_r_bit to a better spot

c3c9683

Since we are moving some code handling out of the dataplane and into zebra proper, lets move the protodown r bit as well. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

zebra: Remove unused dplane_intf_delete

cd7324d

There is no need for this functionality and it is not used. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

zebra: Remove unused add variable

bc0bac5

Function was not using the add variable. Remove it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>

donaldsharp force-pushed the interface_is_interface branch from e9309cc to 562f622 Compare July 5, 2023 15:54

github-actions bot removed the conflicts label Jul 5, 2023

donaldsharp added 3 commits July 5, 2023 13:03

donaldsharp force-pushed the interface_is_interface branch from 562f622 to 605df8d Compare July 5, 2023 17:03

riw777 merged commit 1e9e82e into FRRouting:master Jul 6, 2023
5 checks passed

dgsudharsan mentioned this pull request Jul 26, 2023

[frr]FRR 8.5.1 integration changes sonic-net/sonic-buildimage#15965

Merged

11 tasks

mssonicbld mentioned this pull request Aug 19, 2023

[action] [PR:15965] [frr]FRR 8.5.1 integration changes sonic-net/sonic-buildimage#16212

Merged

11 tasks

dgsudharsan mentioned this pull request Apr 12, 2024

[FRR]Upgrade FRR to 8.5.4 sonic-net/sonic-buildimage#18669

Merged

11 tasks

move interface ( LINK and ADDR ) events to the dplane #13396

move interface ( LINK and ADDR ) events to the dplane #13396

Conversation

donaldsharp commented Apr 27, 2023

donaldsharp commented Apr 27, 2023

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

donaldsharp commented Apr 27, 2023

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

3 Static Analyzer issues remaining.

NetDEF-CI commented Apr 27, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

github-actions bot commented May 2, 2023

riw777 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 23, 2023

NetDEF-CI commented Jul 5, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 5, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Apr 27, 2023 •

edited

Loading

NetDEF-CI commented Jul 5, 2023 •

edited

Loading

NetDEF-CI commented Jul 5, 2023 •

edited

Loading

NetDEF-CI commented Jul 6, 2023 •

edited

Loading