bgpd: fix and improve snmp peer lookups #2207
Conversation
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3583/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base6 Static Analyzer issues remaining.See details at |
The previous implementation of bgp_peer_lookup_next did not consider the internal ordering of peers when using peer groups, which led to all standalone peers being skipped that had a lower IP address than the highest IP address of a peer belonging to a group. As the ordering of peers can not be arbitrary due to SNMP requiring increasing OIDs when walking an OID tree, this commit fixes the bug by properly looping through all peers and detecting the next highest IP address. Additionally, this commit improved both bgp_peer_lookup_next and peer_lookup_addr_ipv4 by using the socketunion stored within the peer struct (peer->su) instead of calling inet_pton for each peer during comparison. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
ppmathis
force-pushed
the
fix/bgpd-snmp-peer-lookup
branch
from
f271114
to
2b8e62f
Compare
|
@stannous Thank you for your feedback, seems I forgot about cleaning up the variables after trying several variants/solutions. I have updated the PR accordingly. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3589/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base6 Static Analyzer issues remaining.See details at |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
…ups` (FRRouting/frr#2207) Package-Manager: Portage-2.3.24, Repoman-2.3.6
…ups` (FRRouting/frr#2207) (#10) Package-Manager: Portage-2.3.24, Repoman-2.3.6
The previous implementation of bgp_peer_lookup_next did not consider the
internal ordering of peers when using peer groups, which led to all
standalone peers being skipped that had a lower IP address than the
highest IP address of a peer belonging to a group.
As the ordering of peers can not be arbitrary due to SNMP requiring
increasing OIDs when walking an OID tree, this commit fixes the bug by
properly looping through all peers and detecting the next highest IP
address.
Additionally, this commit improved both bgp_peer_lookup_next and
peer_lookup_addr_ipv4 by using the socketunion stored within the peer
struct (peer->su) instead of calling inet_pton for each peer during
comparison.
Fixes #1190
Signed-off-by: Pascal Mathis mail@pascalmathis.com