build, yang: bump libyang minimum required version to 1.0.184 #6376
Conversation
|
NOTE: this PR should fail in the CI, which needs to be updated to use libyang 1.x. @mwinter-osr is already working on this. |
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 18.04 ppc64le build: Failed (click for details)Configure failed for Ubuntu 18.04 ppc64le build: Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/U1804PPC64LEBUILD/config.log/config.log Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI021BUILD/config.log/config.logConfigure failed for Debian 9 amd64 build: Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/U1604I386/config.log/config.log NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI012BUILD/config.log/config.logConfigure failed for NetBSD 8 amd64 build: Ubuntu 16.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI014BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build: Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/U2004AMD64BUILD/config.log/config.log Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build: Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build: Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/F29BUILD/config.log/config.log OpenBSD 6 amd64 build: Failed (click for details)Configure failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI011BUILD/config.log/config.log FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI009BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build: CentOS 7 amd64 build: Failed (click for details)Configure failed for CentOS 7 amd64 build: CentOS 7 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/CI005BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build: Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12235/artifact/U1804AMD64/config.log/config.log |
It's time to say good bye to libyang 0.16.105. The recently released libyang 1.0.184 includes numerous bug fixes and performance improvements that we need. Despite the major version bump from 0.x to 1.x, the libyang API is the same except for a single backward-incompatible change in the user types interface (which we're currently not using). Hence no code changes were necessary to adapt FRR to libyang 1.x. This commit also reintroduces some leafrefs that needed to be removed from our YANG modules due to a bug that was present on libyang 0.16.105. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
rwestphal
force-pushed
the
bump-libyang-req-version-1.x
branch
from
fb24aa8
to
240b782
Compare
rwestphal
changed the title
|
Updated PR to use libyang 1.0.184 which was released a few weeks ago. |
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/U2004AMD64BUILD/config.log/config.logConfigure failed for Ubuntu 20.04 amd64 build: Ubuntu 18.04 arm7 build: Failed (click for details)Configure failed for Ubuntu 18.04 arm7 build: Ubuntu 18.04 ppc64le build: Failed (click for details)Configure failed for Ubuntu 18.04 ppc64le build: Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/U1804PPC64LEBUILD/config.log/config.log Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build: Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/F29BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build: CentOS 7 amd64 build: Failed (click for details)Configure failed for CentOS 7 amd64 build: CentOS 7 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI005BUILD/config.log/config.log Ubuntu 18.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 18.04 arm8 build: Ubuntu 16.04 arm7 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm7 build: Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build: Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build: FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/FBSD12AMD64/config.log/config.log OpenBSD 6 amd64 build: Failed (click for details)Configure failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI011BUILD/config.log/config.log NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI012BUILD/config.log/config.logConfigure failed for NetBSD 8 amd64 build: Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI021BUILD/config.log/config.logConfigure failed for Debian 9 amd64 build: FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI009BUILD/config.log/config.log Ubuntu 16.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/CI014BUILD/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build: Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13521/artifact/U1804AMD64/config.log/config.log |
Outdated results 🚧Basic BGPD CI results: Partial FAILURE, 0 tests failed, has VALGRIND issues
For details, please contact louberger |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
|
should be merged with #7032 |
PR FRRouting#6376 introduced a VRF leafref in the frr-interface YANG module. That change exposed a bug in the northbound layer that is causing pbrd to crash under certain circumstances. Even though pbrd wasn't converted to the new northbound model yet, make it implement the frr-vrf module in order to work around this problem. This is a temporary fix until a better solution is available. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
PR FRRouting#6376 introduced a VRF leafref in the frr-interface YANG module. That change exposed a bug in the northbound layer that is causing pbrd to crash under certain circumstances. Even though pbrd wasn't converted to the new northbound model yet, make it implement the frr-vrf module in order to work around this problem. This is a temporary fix until a better solution is available. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
PR FRRouting#6376 introduced a VRF leafref in the frr-interface YANG module. That change exposed a bug in the northbound layer that is causing nhrpd to crash under certain circumstances. Even though nhrpd wasn't converted to the new northbound model yet, make it implement the frr-vrf module in order to work around this problem. This is a temporary fix until a better solution is available. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
PR FRRouting#6376 introduced a VRF leafref in the frr-interface YANG module. That change exposed a bug in the northbound layer that is causing nhrpd to crash under certain circumstances. Even though nhrpd wasn't converted to the new northbound model yet, make it implement the frr-vrf module in order to work around this problem. This is a temporary fix until a better solution is available. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
It's time to say good bye to libyang 0.16.105. The recently
released libyang 1.0.167 includes numerous bug fixes and performance
improvements that we need.
Despite the major version bump from 0.x to 1.x, the libyang API is
the same except for a single backward-incompatible change in the
user types interface (which we're currently not using). Hence no
code changes were necessary to adapt FRR to libyang 1.x.
This commit also reintroduces some leafrefs that needed to be
removed from our YANG modules due to a bug that was present on
libyang 0.16.105.
Signed-off-by: Renato Westphal renato@opensourcerouting.org