nhrp, ospf: add nhrp multicast for OSPF DMVPN #8153

reubendowle · 2021-02-25T21:14:33Z

This pull requests adds nhrp multicast support, and enables the use of OSPF within a DMVPN network.

NetDEF-CI · 2021-02-25T21:42:45Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI021BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U2004AMD64BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/DEB10BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI008BLD/config.log/config.log.gz

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from ./lib/thread.h:30:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/xref.h:227:22: error: format %d expects argument of type int, but argument 6 has type size_t [-Werror=format=]
./lib/zlog.h:97:3: note: in expansion of macro XREF_LINK
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/xref.h:227:22: error: format %d expects argument of type int, but argument 7 has type size_t [-Werror=format=]

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CI008BLD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/F29BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/U1804AMD64/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
./lib/zlog.h:98:20: error: format %d expects argument of type int, but argument 7 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:105:26: note: in expansion of macro _zlog_ref

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17324/artifact/CENTOS8BUILD/config.log/config.log.gz

Successful on other platforms/tests

NetBSD 8 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 i386 build
FreeBSD 11 amd64 build
OpenBSD 6 amd64 build
CentOS 7 amd64 build
FreeBSD 12 amd64 build
Ubuntu 16.04 arm7 build

LabN-CI · 2021-02-25T21:55:05Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/8153 `44d0fc3` (merge failed)
Date	02/25/2021
Start	16:15:38
Finish	16:55:03
Run-Time	39:25
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-02-25-16:15:38.txt
Log	autoscript-2021-02-25-16:16:47.log.bz2
Memory	477 461 427

For details, please contact louberger

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/fb075323e94974d7328bc019c5c8e405/raw/7c670b1e7144d772f24ea750b11408cf7aa7ecf1/cr_8153_1614291670.diff | git apply

diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c
index da779c9ea..5ab584daf 100644
--- a/ospfd/ospf_lsa.c
+++ b/ospfd/ospf_lsa.c
@@ -488,7 +488,8 @@ static int lsa_link_ptop_set(struct stream **s, struct ospf_interface *oi)
 	if ((nbr = ospf_nbr_lookup_ptop(oi)))
 		if (nbr->state == NSM_Full) {
 			if (CHECK_FLAG(oi->connected->flags,
-				       ZEBRA_IFA_UNNUMBERED) && !oi->ptp_dmvpn) {
+				       ZEBRA_IFA_UNNUMBERED)
+			    && !oi->ptp_dmvpn) {
 				/* For unnumbered point-to-point networks, the
 				   Link Data field
 				   should specify the interface's MIB-II ifIndex
@@ -506,7 +507,8 @@ static int lsa_link_ptop_set(struct stream **s, struct ospf_interface *oi)
 		}
 
 	/* no need for a stub link for unnumbered interfaces */
-	if (oi->ptp_dmvpn || !CHECK_FLAG(oi->connected->flags, ZEBRA_IFA_UNNUMBERED)) {
+	if (oi->ptp_dmvpn
+	    || !CHECK_FLAG(oi->connected->flags, ZEBRA_IFA_UNNUMBERED)) {
 		/* Regardless of the state of the neighboring router, we must
 		   add a Type 3 link (stub network).
 		   N.B. Options 1 & 2 share basically the same logic. */
diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
index 8199eb67e..5307da1b6 100644
--- a/ospfd/ospf_vty.c
+++ b/ospfd/ospf_vty.c
@@ -8346,17 +8346,16 @@ DEFUN_HIDDEN (no_ospf_hello_interval,
 	return no_ip_ospf_hello_interval(self, vty, argc, argv);
 }
 
-DEFUN (ip_ospf_network,
-       ip_ospf_network_cmd,
-       "ip ospf network <broadcast|non-broadcast|point-to-multipoint|point-to-point [dmvpn]>",
-       "IP Information\n"
-       "OSPF interface commands\n"
-       "Network type\n"
-       "Specify OSPF broadcast multi-access network\n"
-       "Specify OSPF NBMA network\n"
-       "Specify OSPF point-to-multipoint network\n"
-       "Specify OSPF point-to-point network\n"
-       "Specify OSPF point-to-point DMVPN network\n")
+DEFUN(ip_ospf_network, ip_ospf_network_cmd,
+      "ip ospf network <broadcast|non-broadcast|point-to-multipoint|point-to-point [dmvpn]>",
+      "IP Information\n"
+      "OSPF interface commands\n"
+      "Network type\n"
+      "Specify OSPF broadcast multi-access network\n"
+      "Specify OSPF NBMA network\n"
+      "Specify OSPF point-to-multipoint network\n"
+      "Specify OSPF point-to-point network\n"
+      "Specify OSPF point-to-point DMVPN network\n")
 {
 	VTY_DECLVAR_CONTEXT(interface, ifp);
 	int idx = 0;
@@ -8385,7 +8384,7 @@ DEFUN (ip_ospf_network,
 	}
 
 	if (IF_DEF_PARAMS(ifp)->type == old_type
-		&& IF_DEF_PARAMS(ifp)->ptp_dmvpn == old_ptp_dmvpn)
+	    && IF_DEF_PARAMS(ifp)->ptp_dmvpn == old_ptp_dmvpn)
 		return CMD_SUCCESS;
 
 	SET_IF_PARAM(IF_DEF_PARAMS(ifp), type);
@@ -11583,8 +11582,9 @@ static int config_write_interface_one(struct vty *vty, struct vrf *vrf)
 					vty_out(vty, " ip ospf network %s",
 						ospf_int_type_str
 							[params->type]);
-					if (params->type == OSPF_IFTYPE_POINTOPOINT
-						&& params->ptp_dmvpn)
+					if (params->type
+						    == OSPF_IFTYPE_POINTOPOINT
+					    && params->ptp_dmvpn)
 						vty_out(vty, " dmvpn");
 					if (params != IF_DEF_PARAMS(ifp) && rn)
 						vty_out(vty, " %pI4",

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2021-02-25T22:50:08Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8606: nhrpd/nhrp_multicast.o] Error 1
copying selected object files to avoid basename conflicts...

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U2004AMD64BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI021BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8605: nhrpd/nhrp_multicast.o] Error 1

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/F29BUILD/config.log/config.log.gz

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI008BLD/config.log/config.log.gz

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from ./lib/thread.h:30:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/xref.h:227:22: error: format %d expects argument of type int, but argument 6 has type size_t [-Werror=format=]
./lib/zlog.h:101:3: note: in expansion of macro XREF_LINK
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI008BLD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8606: nhrpd/nhrp_multicast.o] Error 1

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/DEB10BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804AMD64/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8605: nhrpd/nhrp_multicast.o] Error 1

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CENTOS8BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 18.04 arm7 build
NetBSD 8 amd64 build
Ubuntu 16.04 i386 build
FreeBSD 11 amd64 build
CentOS 7 amd64 build
OpenBSD 6 amd64 build
FreeBSD 12 amd64 build
Ubuntu 16.04 arm7 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8606: nhrpd/nhrp_multicast.o] Error 1
copying selected object files to avoid basename conflicts...

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U2004AMD64BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI021BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8605: nhrpd/nhrp_multicast.o] Error 1

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/F29BUILD/config.log/config.log.gz

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI008BLD/config.log/config.log.gz

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from ./lib/thread.h:30:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/xref.h:227:22: error: format %d expects argument of type int, but argument 6 has type size_t [-Werror=format=]
./lib/zlog.h:101:3: note: in expansion of macro XREF_LINK
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI008BLD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8606: nhrpd/nhrp_multicast.o] Error 1

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/DEB10BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
Makefile:8048: recipe for target 'nhrpd/nhrp_multicast.o' failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/U1804AMD64/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
nhrpd/nhrp_multicast.c: In function nhrp_multicast_send:
./lib/zlog.h:102:20: error: format %d expects argument of type int, but argument 6 has type size_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:109:26: note: in expansion of macro _zlog_ref
 #define zlog_debug(...)  _zlog_ref(LOG_DEBUG, __VA_ARGS__)
nhrpd/debug.h:26:4: note: in expansion of macro zlog_debug
nhrpd/nhrp_multicast.c:54:2: note: in expansion of macro debugf
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8605: nhrpd/nhrp_multicast.o] Error 1

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17325/artifact/CENTOS8BUILD/config.log/config.log.gz

Report for linux.c | 11 issues
===============================================
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#115: FILE: /tmp/f1-22570/linux.c:115:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#114: FILE: /tmp/f2-22570/linux.c:114:
4c4
< total: 0 errors, 1 warnings, 161 lines checked
---
> total: 0 errors, 1 warnings, 160 lines checked
9c9
< /tmp/f1-22570/linux.c has style problems, please review.
---
> /tmp/f2-22570/linux.c has style problems, please review.
Report for nhrpd.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #357: FILE: /tmp/f1-22570/nhrpd.h:357:
< WARNING: line over 80 characters
< #358: FILE: /tmp/f1-22570/nhrpd.h:358:
Report for nhrp_multicast.c | 85 issues
===============================================
WARNING: line over 80 characters
#54: FILE: /tmp/f1-22570/nhrp_multicast.c:54:
+	debugf(NHRP_DEBUG_COMMON, "Multicast Packet: %s -> %s, ret = %d, size = %d, addrlen = %zu",

WARNING: line over 80 characters
#60: FILE: /tmp/f1-22570/nhrp_multicast.c:60:
+static void nhrp_multicast_forward_nbma(union sockunion *nbma_addr, struct interface *ifp, struct zbuf *pkt)

WARNING: Missing a blank line after declarations
#63: FILE: /tmp/f1-22570/nhrp_multicast.c:63:
+	struct nhrp_peer *p = nhrp_peer_get(ifp, nbma_addr);
+	if(p && p->online) {

ERROR: space required before the open parenthesis '('
#63: FILE: /tmp/f1-22570/nhrp_multicast.c:63:
+	if(p && p->online) {

WARNING: line over 80 characters
#75: FILE: /tmp/f1-22570/nhrp_multicast.c:75:
+		nhrp_multicast_forward_nbma(&c->cur.peer->vc->remote.nbma, ctx->ifp, ctx->pkt);

WARNING: line over 80 characters
#88: FILE: /tmp/f1-22570/nhrp_multicast.c:88:
+		nhrp_cache_foreach(ctx->ifp, nhrp_multicast_forward_cache, pctx);

ERROR: space required after that ',' (ctx:VxV)
#106: FILE: /tmp/f1-22570/nhrp_multicast.c:106:
+	debugf(NHRP_DEBUG_COMMON,"Inside %s\n", __func__);
 	                        ^

WARNING: Block comments use a trailing */ on a separate line
#124: FILE: /tmp/f1-22570/nhrp_multicast.c:124:
+			 * route. */

ERROR: space required after that ',' (ctx:VxV)
#135: FILE: /tmp/f1-22570/nhrp_multicast.c:135:
+	debugf(NHRP_DEBUG_COMMON,"Outgoing interface = %s\n", ifp->name);
 	                        ^

WARNING: braces {} are not necessary for single statement blocks
#142: FILE: /tmp/f1-22570/nhrp_multicast.c:142:
+	for (afi = 0; afi < AFI_MAX; afi++) {
+		nhrp_multicast_foreach(ifp, afi, nhrp_multicast_forward, (void *)&ctx);
+	}

WARNING: line over 80 characters
#143: FILE: /tmp/f1-22570/nhrp_multicast.c:143:
+		nhrp_multicast_foreach(ifp, afi, nhrp_multicast_forward, (void *)&ctx);

WARNING: line over 80 characters
#214: FILE: /tmp/f1-22570/nhrp_multicast.c:214:
+		thread_add_read(master, netlink_mcast_log_recv, 0, netlink_mcast_log_fd,

WARNING: line over 80 characters
#216: FILE: /tmp/f1-22570/nhrp_multicast.c:216:
+		debugf(NHRP_DEBUG_COMMON, "Register nflog group: %d", netlink_mcast_nflog_group);

WARNING: line over 80 characters
#220: FILE: /tmp/f1-22570/nhrp_multicast.c:220:
+static int nhrp_multicast_free(struct interface *ifp, struct nhrp_multicast *mcast)

WARNING: line over 80 characters
#229: FILE: /tmp/f1-22570/nhrp_multicast.c:229:
+int nhrp_multicast_add(struct interface *ifp, afi_t afi, union sockunion *nbma_addr)

WARNING: line over 80 characters
#256: FILE: /tmp/f1-22570/nhrp_multicast.c:256:
+	debugf(NHRP_DEBUG_COMMON, "Adding multicast entry (%s) [%d]", buf, nhrp_multicast_ip_count);

WARNING: line over 80 characters
#261: FILE: /tmp/f1-22570/nhrp_multicast.c:261:
+int nhrp_multicast_del(struct interface *ifp, afi_t afi, union sockunion *nbma_addr)

WARNING: line over 80 characters
#274: FILE: /tmp/f1-22570/nhrp_multicast.c:274:
+		debugf(NHRP_DEBUG_COMMON, "Deleting multicast entry (%s) [%d]", buf, nhrp_multicast_ip_count);

WARNING: line over 80 characters
#291: FILE: /tmp/f1-22570/nhrp_multicast.c:291:
+		debugf(NHRP_DEBUG_COMMON, "Cleaning up multicast entries (%d, %d)", !list_empty(&nifp->afi[afi].mcastlist_head), nhrp_multicast_ip_count);

WARNING: space prohibited between function name and open parenthesis '('
#310: FILE: /tmp/f1-22570/nhrp_multicast.c:310:
+		cb (mcast, ctx);
Report for nhrp_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1170: FILE: /tmp/f1-22570/nhrp_vty.c:1170:
Report for ospf_lsa.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #491: FILE: /tmp/f1-22570/ospf_lsa.c:491:
< WARNING: line over 80 characters
< #509: FILE: /tmp/f1-22570/ospf_lsa.c:509:
Report for ospf_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #11586: FILE: /tmp/f1-22570/ospf_vty.c:11586:

LabN-CI · 2021-02-25T23:05:19Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8153 `25fcd79`
Date	02/25/2021
Start	17:26:02
Finish	18:05:16
Run-Time	39:14
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-02-25-17:26:02.txt
Log	autoscript-2021-02-25-17:27:05.log.bz2
Memory	496 492 427

For details, please contact louberger

LabN-CI · 2021-02-25T23:55:18Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8153 `b758fdc`
Date	02/25/2021
Start	18:16:03
Finish	18:55:15
Run-Time	39:12
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-02-25-18:16:03.txt
Log	autoscript-2021-02-25-18:17:05.log.bz2
Memory	497 484 428

For details, please contact louberger

NetDEF-CI · 2021-02-26T02:34:20Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17326/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for linux.c | 11 issues
===============================================
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#115: FILE: /tmp/f1-5190/linux.c:115:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#114: FILE: /tmp/f2-5190/linux.c:114:
4c4
< total: 0 errors, 1 warnings, 161 lines checked
---
> total: 0 errors, 1 warnings, 160 lines checked
9c9
< /tmp/f1-5190/linux.c has style problems, please review.
---
> /tmp/f2-5190/linux.c has style problems, please review.
Report for nhrpd.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #357: FILE: /tmp/f1-5190/nhrpd.h:357:
< WARNING: line over 80 characters
< #358: FILE: /tmp/f1-5190/nhrpd.h:358:
Report for nhrp_multicast.c | 85 issues
===============================================
WARNING: line over 80 characters
#54: FILE: /tmp/f1-5190/nhrp_multicast.c:54:
+	debugf(NHRP_DEBUG_COMMON, "Multicast Packet: %s -> %s, ret = %d, size = %zu, addrlen = %zu",

WARNING: line over 80 characters
#60: FILE: /tmp/f1-5190/nhrp_multicast.c:60:
+static void nhrp_multicast_forward_nbma(union sockunion *nbma_addr, struct interface *ifp, struct zbuf *pkt)

WARNING: Missing a blank line after declarations
#63: FILE: /tmp/f1-5190/nhrp_multicast.c:63:
+	struct nhrp_peer *p = nhrp_peer_get(ifp, nbma_addr);
+	if(p && p->online) {

ERROR: space required before the open parenthesis '('
#63: FILE: /tmp/f1-5190/nhrp_multicast.c:63:
+	if(p && p->online) {

WARNING: line over 80 characters
#75: FILE: /tmp/f1-5190/nhrp_multicast.c:75:
+		nhrp_multicast_forward_nbma(&c->cur.peer->vc->remote.nbma, ctx->ifp, ctx->pkt);

WARNING: line over 80 characters
#88: FILE: /tmp/f1-5190/nhrp_multicast.c:88:
+		nhrp_cache_foreach(ctx->ifp, nhrp_multicast_forward_cache, pctx);

ERROR: space required after that ',' (ctx:VxV)
#106: FILE: /tmp/f1-5190/nhrp_multicast.c:106:
+	debugf(NHRP_DEBUG_COMMON,"Inside %s\n", __func__);
 	                        ^

WARNING: Block comments use a trailing */ on a separate line
#124: FILE: /tmp/f1-5190/nhrp_multicast.c:124:
+			 * route. */

ERROR: space required after that ',' (ctx:VxV)
#135: FILE: /tmp/f1-5190/nhrp_multicast.c:135:
+	debugf(NHRP_DEBUG_COMMON,"Outgoing interface = %s\n", ifp->name);
 	                        ^

WARNING: braces {} are not necessary for single statement blocks
#142: FILE: /tmp/f1-5190/nhrp_multicast.c:142:
+	for (afi = 0; afi < AFI_MAX; afi++) {
+		nhrp_multicast_foreach(ifp, afi, nhrp_multicast_forward, (void *)&ctx);
+	}

WARNING: line over 80 characters
#143: FILE: /tmp/f1-5190/nhrp_multicast.c:143:
+		nhrp_multicast_foreach(ifp, afi, nhrp_multicast_forward, (void *)&ctx);

WARNING: line over 80 characters
#214: FILE: /tmp/f1-5190/nhrp_multicast.c:214:
+		thread_add_read(master, netlink_mcast_log_recv, 0, netlink_mcast_log_fd,

WARNING: line over 80 characters
#216: FILE: /tmp/f1-5190/nhrp_multicast.c:216:
+		debugf(NHRP_DEBUG_COMMON, "Register nflog group: %d", netlink_mcast_nflog_group);

WARNING: line over 80 characters
#220: FILE: /tmp/f1-5190/nhrp_multicast.c:220:
+static int nhrp_multicast_free(struct interface *ifp, struct nhrp_multicast *mcast)

WARNING: line over 80 characters
#229: FILE: /tmp/f1-5190/nhrp_multicast.c:229:
+int nhrp_multicast_add(struct interface *ifp, afi_t afi, union sockunion *nbma_addr)

WARNING: line over 80 characters
#256: FILE: /tmp/f1-5190/nhrp_multicast.c:256:
+	debugf(NHRP_DEBUG_COMMON, "Adding multicast entry (%s) [%d]", buf, nhrp_multicast_ip_count);

WARNING: line over 80 characters
#261: FILE: /tmp/f1-5190/nhrp_multicast.c:261:
+int nhrp_multicast_del(struct interface *ifp, afi_t afi, union sockunion *nbma_addr)

WARNING: line over 80 characters
#274: FILE: /tmp/f1-5190/nhrp_multicast.c:274:
+		debugf(NHRP_DEBUG_COMMON, "Deleting multicast entry (%s) [%d]", buf, nhrp_multicast_ip_count);

WARNING: line over 80 characters
#291: FILE: /tmp/f1-5190/nhrp_multicast.c:291:
+		debugf(NHRP_DEBUG_COMMON, "Cleaning up multicast entries (%d, %d)", !list_empty(&nifp->afi[afi].mcastlist_head), nhrp_multicast_ip_count);

WARNING: space prohibited between function name and open parenthesis '('
#310: FILE: /tmp/f1-5190/nhrp_multicast.c:310:
+		cb (mcast, ctx);
Report for nhrp_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1170: FILE: /tmp/f1-5190/nhrp_vty.c:1170:

Jafaral · 2021-02-26T06:44:50Z

fixes #6276

Jafaral · 2021-02-26T17:47:29Z

@reubendowle Thank you for this excellent contribution! Can you please fix the build warnings ?

donaldsharp · 2021-02-26T18:10:58Z

doc changes and topotest?

reubendowle · 2021-02-26T20:18:06Z

doc changes and topotest?

The new commands are already documented as part of the pull request. Is that sufficient?

I am not familiar with the topotests. How would I go about adding that?

Jafaral · 2021-02-26T21:04:50Z

We don't have any topotests for nhrp but we can start somewhere. Example for other protocols :

https://github.com/FRRouting/frr/tree/master/tests/topotests

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
One of your commits does not have a blank line between the summary and body; this will break git log --oneline

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

blocking comments addressed

LabN-CI · 2021-02-28T20:55:14Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8153 `374d1ee`
Date	02/28/2021
Start	15:16:04
Finish	15:55:12
Run-Time	39:08
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-02-28-15:16:04.txt
Log	autoscript-2021-02-28-15:17:03.log.bz2
Memory	494 504 427

For details, please contact louberger

NetDEF-CI · 2021-02-28T23:05:07Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17361/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details)

CentOS 7 rpm pkg check: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 16.04 i386 part 1
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 16.04 i386 part 0
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 16.04 amd64 part 2
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 16.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Topotests Ubuntu 16.04 amd64 part 6
Topotests Ubuntu 16.04 i386 part 3
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 16.04 amd64 part 9
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 16.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Debian 8 deb pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 7
Fedora 29 rpm pkg check
Topotests Ubuntu 16.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 16.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 1
Addresssanitizer topotests part 0
Topotests Ubuntu 16.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 16.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1
Addresssanitizer topotests part 4
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings

CentOS 7 rpm pkg check: Failed (click for details)

CentOS 7 rpm pkg check: No useful log found

Report for linux.c | 11 issues
===============================================
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#115: FILE: /tmp/f1-22583/linux.c:115:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#114: FILE: /tmp/f2-22583/linux.c:114:
4c4
< total: 0 errors, 1 warnings, 161 lines checked
---
> total: 0 errors, 1 warnings, 160 lines checked
9c9
< /tmp/f1-22583/linux.c has style problems, please review.
---
> /tmp/f2-22583/linux.c has style problems, please review.
Report for nhrp_multicast.c | 9 issues
===============================================
WARNING: Missing a blank line after declarations
#65: FILE: /tmp/f1-22583/nhrp_multicast.c:65:
+	struct nhrp_peer *p = nhrp_peer_get(ifp, nbma_addr);
+	if (p && p->online) {

WARNING: Block comments use a trailing */ on a separate line
#128: FILE: /tmp/f1-22583/nhrp_multicast.c:128:
+			 * route. */
Report for nhrp_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1170: FILE: /tmp/f1-22583/nhrp_vty.c:1170:

NetDEF-CI · 2021-02-28T23:58:01Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17362/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details)

CentOS 7 rpm pkg check: No useful log found

Successful on other platforms/tests

Ubuntu 16.04 deb pkg check
Topotests Ubuntu 16.04 i386 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 16.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Topotests Ubuntu 16.04 amd64 part 6
Topotests Ubuntu 16.04 i386 part 8
Topotests Ubuntu 16.04 i386 part 3
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 3
Topotests Ubuntu 16.04 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 16.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Debian 8 deb pkg check
Addresssanitizer topotests part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 16.04 amd64 part 3
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 0
Fedora 29 rpm pkg check
Topotests Ubuntu 16.04 i386 part 7
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 4
Static analyzer (clang)
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 16.04 i386 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 16.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1
Addresssanitizer topotests part 4
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

CentOS 7 rpm pkg check: Failed (click for details)

CentOS 7 rpm pkg check: No useful log found

Report for linux.c | 11 issues
===============================================
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#115: FILE: /tmp/f1-26196/linux.c:115:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#114: FILE: /tmp/f2-26196/linux.c:114:
4c4
< total: 0 errors, 1 warnings, 161 lines checked
---
> total: 0 errors, 1 warnings, 160 lines checked
9c9
< /tmp/f1-26196/linux.c has style problems, please review.
---
> /tmp/f2-26196/linux.c has style problems, please review.
Report for nhrp_multicast.c | 9 issues
===============================================
WARNING: Missing a blank line after declarations
#65: FILE: /tmp/f1-26196/nhrp_multicast.c:65:
+	struct nhrp_peer *p = nhrp_peer_get(ifp, nbma_addr);
+	if (p && p->online) {

WARNING: Block comments use a trailing */ on a separate line
#128: FILE: /tmp/f1-26196/nhrp_multicast.c:128:
+			 * route. */
Report for nhrp_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1170: FILE: /tmp/f1-26196/nhrp_vty.c:1170:

LabN-CI · 2021-03-02T04:30:26Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8153 `51a526e`
Date	03/01/2021
Start	22:51:06
Finish	23:30:23
Run-Time	39:17
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-03-01-22:51:06.txt
Log	autoscript-2021-03-01-22:52:07.log.bz2
Memory	492 488 428

For details, please contact louberger

NetDEF-CI · 2021-03-02T07:28:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17398/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for linux.c | 11 issues
===============================================
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#115: FILE: /tmp/f1-31410/linux.c:115:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#114: FILE: /tmp/f2-31410/linux.c:114:
4c4
< total: 0 errors, 1 warnings, 161 lines checked
---
> total: 0 errors, 1 warnings, 160 lines checked
9c9
< /tmp/f1-31410/linux.c has style problems, please review.
---
> /tmp/f2-31410/linux.c has style problems, please review.
Report for nhrp_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1170: FILE: /tmp/f1-31410/nhrp_vty.c:1170:

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

Operation with PMP network on /32 prefix is needed for DMVPN Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

When ip nhrp map multicast is being used, this is usually accompanied by an iptables rule to block the original multicast packet. This causes sendmsg to return EPERM. Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

LabN-CI · 2021-04-05T22:13:14Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/8153 `c2bb991`
Date	04/05/2021
Start	17:31:09
Finish	18:13:11
Run-Time	42:02
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-04-05-17:31:09.txt
Log	autoscript-2021-04-05-17:32:20.log.bz2
Memory	481 499 429

For details, please contact louberger

NetDEF-CI · 2021-04-06T01:13:21Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18188/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Topotests Ubuntu 16.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U16I386-18188/test

Topology Tests failed for Topotests Ubuntu 16.04 i386 part 9:

2021-04-06 00:07:24,431 ERROR: 'router_json_cmp' failed after 134.04 seconds
2021-04-06 00:07:24,435 ERROR: assert failed at "test_ospf_te_topo1/test_step1": "r3" TED JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->ted->edges: d2 has the following element at index 6 which is not present in d1: 
  
  	{
  	    "status": "Sync",
  	    "origin": "OSPFv2",
  	    "advertised-router": "10.0.255.4",
  	    "local-vertex-id": 167837444,
  	    "metric": 10,
  	    "remote-vertex-id": 167837442,
  	    "edge-id": 167773185,
  	    "segment-routing": [
  	        {
  	            "adj-sid": 5001,
  	            "flags": "0x60",
  	            "weight": 0
  	        },
  	        {
  	            "adj-sid": 5000,
  	            "flags": "0xe0",
  	            "weight": 0
  	        }
  	    ],
  	    "edge-attributes": {
  	        "remote-address": "10.0.4.2",
  	        "max-link-bandwidth": 176258176.0,
  	        "max-resv-link-bandwidth": 176258176.0,
  	        "local-address": "10.0.4.1",
  	        "te-metric": 0,
  	        "unreserved-bandwidth": [
  	            {
  	                "class-type-0": 176258176.0
  	            },
  	            {
  	                "class-type-1": 176258176.0
  	            },
  	            {
  	                "class-type-2": 176258176.0
  	            },
  	            {
  	                "class-type-3": 176258176.0
  	            },
  	            {
  	                "class-type-4": 176258176.0
  	            },
  	            {
  	                "class-type-5": 176258176.0
  	            },
  	            {
  	                "class-type-6": 176258176.0
  	            },
  	            {
  	                "class-type-7": 176258176.0
  	            }
  	        ]
  	    }
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->ted->edges[0]->segment-routing: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "adj-sid": 5001,
  		    "flags": "0x60",
  		    "weight": 0
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->ted->edges[0]->segment-routing[1]->adj-sid: d1 has element with value '5000' but in d2 it has value '5001'
  		> $->ted->edges[0]->segment-routing[1]->flags: d1 has element with value '0xe0' but in d2 it has value '0x60'
  	
  
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2021-04-06 00:14:47,132 WARNING: vtysh_cmd: failed to convert json output
2021-04-06 00:15:11,638 WARNING: vtysh_cmd: failed to convert json output
2021-04-06 00:25:30,900 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 1689, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-04-06 00:26:10,744 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 1689, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18188/artifact/TOPO9U16I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 7
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 16.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 16.04 amd64 part 7
Fedora 29 rpm pkg check
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 16.04 i386 part 5
CentOS 7 rpm pkg check
Topotests Ubuntu 16.04 amd64 part 0
Addresssanitizer topotests part 0
Topotests Ubuntu 16.04 i386 part 7
Topotests Ubuntu 16.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 8
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 16.04 amd64 part 2
Addresssanitizer topotests part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 16.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 16.04 i386 part 1
Topotests Ubuntu 16.04 amd64 part 6
Topotests Ubuntu 16.04 i386 part 8
Topotests Ubuntu 16.04 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 16.04 amd64 part 8
Debian 8 deb pkg check
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Topotests Ubuntu 16.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U16I386-18188/test

Topology Tests failed for Topotests Ubuntu 16.04 i386 part 9:

2021-04-06 00:07:24,431 ERROR: 'router_json_cmp' failed after 134.04 seconds
2021-04-06 00:07:24,435 ERROR: assert failed at "test_ospf_te_topo1/test_step1": "r3" TED JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->ted->edges: d2 has the following element at index 6 which is not present in d1: 
  
  	{
  	    "status": "Sync",
  	    "origin": "OSPFv2",
  	    "advertised-router": "10.0.255.4",
  	    "local-vertex-id": 167837444,
  	    "metric": 10,
  	    "remote-vertex-id": 167837442,
  	    "edge-id": 167773185,
  	    "segment-routing": [
  	        {
  	            "adj-sid": 5001,
  	            "flags": "0x60",
  	            "weight": 0
  	        },
  	        {
  	            "adj-sid": 5000,
  	            "flags": "0xe0",
  	            "weight": 0
  	        }
  	    ],
  	    "edge-attributes": {
  	        "remote-address": "10.0.4.2",
  	        "max-link-bandwidth": 176258176.0,
  	        "max-resv-link-bandwidth": 176258176.0,
  	        "local-address": "10.0.4.1",
  	        "te-metric": 0,
  	        "unreserved-bandwidth": [
  	            {
  	                "class-type-0": 176258176.0
  	            },
  	            {
  	                "class-type-1": 176258176.0
  	            },
  	            {
  	                "class-type-2": 176258176.0
  	            },
  	            {
  	                "class-type-3": 176258176.0
  	            },
  	            {
  	                "class-type-4": 176258176.0
  	            },
  	            {
  	                "class-type-5": 176258176.0
  	            },
  	            {
  	                "class-type-6": 176258176.0
  	            },
  	            {
  	                "class-type-7": 176258176.0
  	            }
  	        ]
  	    }
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->ted->edges[0]->segment-routing: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "adj-sid": 5001,
  		    "flags": "0x60",
  		    "weight": 0
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->ted->edges[0]->segment-routing[1]->adj-sid: d1 has element with value '5000' but in d2 it has value '5001'
  		> $->ted->edges[0]->segment-routing[1]->flags: d1 has element with value '0xe0' but in d2 it has value '0x60'
  	
  
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2021-04-06 00:14:47,132 WARNING: vtysh_cmd: failed to convert json output
2021-04-06 00:15:11,638 WARNING: vtysh_cmd: failed to convert json output
2021-04-06 00:25:30,900 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 1689, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-04-06 00:26:10,744 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 1689, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18188/artifact/TOPO9U16I386/ErrorLog/log_topotests.txt

Report for ospf_spf.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #909: FILE: /tmp/f1-14166/ospf_spf.c:909:
< WARNING: line over 80 characters
< #910: FILE: /tmp/f1-14166/ospf_spf.c:910:

Jafaral · 2021-04-06T14:42:45Z

ci:rerun

NetDEF-CI · 2021-04-06T18:32:00Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18208/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for ospf_spf.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #909: FILE: /tmp/f1-21372/ospf_spf.c:909:
< WARNING: line over 80 characters
< #910: FILE: /tmp/f1-21372/ospf_spf.c:910:

Jafaral

@reubendowle While adding these new comments I realized that that sockunionstr use is spread all over the place in nhrp. If you have bandwidth to make the change for the ones you added please do. If you want to take a pass that would be OK too. I will do a round of cleanup for those anyway. Please let me know.

nhrpd/nhrp_multicast.c

nhrpd/nhrp_vty.c

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

NetDEF-CI · 2021-04-08T00:15:36Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18244/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for nhrp_vty.c | 6 issues
===============================================
< ERROR: space required before the open parenthesis '('
< #1135: FILE: /tmp/f1-14390/nhrp_vty.c:1135:
< ERROR: space required before the open parenthesis '('
< #1208: FILE: /tmp/f1-14390/nhrp_vty.c:1208:
< ERROR: space required before the open parenthesis '('
< #1220: FILE: /tmp/f1-14390/nhrp_vty.c:1220:
Report for ospf_spf.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #909: FILE: /tmp/f1-14390/ospf_spf.c:909:
< WARNING: line over 80 characters
< #910: FILE: /tmp/f1-14390/ospf_spf.c:910:

LabN-CI · 2021-04-08T00:43:51Z

🚧 Basic BGPD CI results: Partial FAILURE, 3 tests failed

Results table

_	_
Result	3
Date	0
Start	0
Finish	vncregress-2021-04-07-20:00:15.txt
Run-Time	autoscript-2021-04-07-20:01:29.log.bz2
Total	504 505 429
Pass	SUCCESS git master `d459ca2`
Fail	02/03/2021
Valgrind-Errors	20:00:18
Valgrind-Loss	20:39:46
Details	39:28
Log	1815
Memory	1815
SUCCESS git merge/8153 `46d3c18`	0
04/07/2021	0
20:00:15	0
20:43:46	vncregress-2021-02-03-20:00:18.txt
43:31	autoscript-2021-02-03-20:01:21.log.bz2
1815	475 505 427
1812

For details, please contact louberger

NetDEF-CI · 2021-04-08T00:44:07Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18246/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Successful on other platforms/tests

Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 16.04 i386 part 8
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 16.04 i386 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 16.04 i386 part 1
Topotests Ubuntu 16.04 amd64 part 8
Topotests Ubuntu 16.04 amd64 part 6
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Debian 8 deb pkg check
Debian 9 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 16.04 i386 part 3
Addresssanitizer topotests part 3
Topotests Ubuntu 16.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 2
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 16.04 amd64 part 3
Addresssanitizer topotests part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 16.04 i386 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 16.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests Ubuntu 16.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 5
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 16.04 amd64 part 0
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 16.04 i386 part 5
Static analyzer (clang)
Addresssanitizer topotests part 1
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 2
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 16.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Report for ospf_spf.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #909: FILE: /tmp/f1-29888/ospf_spf.c:909:
< WARNING: line over 80 characters
< #910: FILE: /tmp/f1-29888/ospf_spf.c:910:

Jafaral · 2021-04-08T03:13:05Z

ci:rerun

NetDEF-CI · 2021-04-08T06:54:53Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18250/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 16.04 amd64 part 2
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 16.04 i386 part 1
Topotests Ubuntu 16.04 amd64 part 6
Topotests Ubuntu 16.04 i386 part 8
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 20.04 deb pkg check
Debian 8 deb pkg check
Addresssanitizer topotests part 2
Debian 9 deb pkg check
Addresssanitizer topotests part 3
Topotests Ubuntu 16.04 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 16.04 i386 part 3
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 16.04 amd64 part 3
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 5
Topotests Ubuntu 16.04 amd64 part 7
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 0
Fedora 29 rpm pkg check
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 16.04 i386 part 5
Topotests Ubuntu 16.04 amd64 part 0
CentOS 7 rpm pkg check
Topotests Ubuntu 16.04 i386 part 7
Addresssanitizer topotests part 0
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Report for ospf_spf.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #909: FILE: /tmp/f1-24317/ospf_spf.c:909:
< WARNING: line over 80 characters
< #910: FILE: /tmp/f1-24317/ospf_spf.c:910:

Jafaral · 2021-04-12T19:16:54Z

ci:rerun

NetDEF-CI · 2021-04-12T23:01:17Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18353/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for ospf_spf.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #909: FILE: /tmp/f1-19258/ospf_spf.c:909:
< WARNING: line over 80 characters
< #910: FILE: /tmp/f1-19258/ospf_spf.c:910:

polychaeta added nhrp ospf labels Feb 25, 2021

reubendowle force-pushed the nhrp-multicast branch from 44d0fc3 to 25fcd79 Compare February 25, 2021 22:21

polychaeta reviewed Feb 25, 2021

View reviewed changes

reubendowle force-pushed the nhrp-multicast branch from 25fcd79 to b758fdc Compare February 25, 2021 23:13

Jafaral changed the title ~~Add nhrp multicast for OSPF DMVPN~~ nhrp, ospf: add nhrp multicast for OSPF DMVPN Feb 26, 2021

pguibert6WIND self-requested a review February 26, 2021 10:43

Jafaral self-requested a review February 26, 2021 17:45

polychaeta previously requested changes Feb 28, 2021

View reviewed changes

reubendowle force-pushed the nhrp-multicast branch from 72e61f4 to 374d1ee Compare February 28, 2021 20:13

amollad mentioned this pull request Mar 2, 2021

feature request: eigrp neighbor command or ip nhrp map multicast command for dmvpn #6276

Open

reubendowle force-pushed the nhrp-multicast branch from 374d1ee to 51a526e Compare March 2, 2021 03:47

reubendowle force-pushed the nhrp-multicast branch from 51a526e to bce4cd5 Compare March 2, 2021 22:22

reubendowle and others added 14 commits April 6, 2021 09:22

nhrpd: Document multicast functionality

3c4f65c

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

ospfd: Document option to support dmvpn networks

78980c2

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Use correct printf format specifier

4f7a37a

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Fix style violation issues

0f8595a

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Use strlcpy not unsafe strncpy

ca31749

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Document how to block redirected multicast packets

ab9ad93

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Use ethertype defines instead of hard-coded values

9f7f6d3

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Introduce new - nflog mutlicast-nflog-group (1-65535) - command

9084e20

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Cleanup multicast nflog handler function

63c0a73

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

ospfd: changes for PMP network /32 prefix length

0c5506a

Operation with PMP network on /32 prefix is needed for DMVPN Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Improve debug message for multicast interception

32ff81f

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Add missing semicolon

4946316

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

nhrpd: Fix style issues

c2bb991

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

reubendowle force-pushed the nhrp-multicast branch from 9c7dcbd to c2bb991 Compare April 5, 2021 21:23

Jafaral reviewed Apr 7, 2021

View reviewed changes

nhrpd/nhrp_multicast.c Outdated Show resolved Hide resolved

nhrpd/nhrp_multicast.c Outdated Show resolved Hide resolved

nhrpd/nhrp_multicast.c Outdated Show resolved Hide resolved

nhrpd/nhrp_vty.c Show resolved Hide resolved

nhrpd/nhrp_vty.c Outdated Show resolved Hide resolved

nhrpd: Change sockunion2str to %pSU in a few places

46d3c18

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>

reubendowle force-pushed the nhrp-multicast branch from 68c8c34 to 46d3c18 Compare April 7, 2021 20:46

Jafaral merged commit d75213d into FRRouting:master Apr 13, 2021

nhrp, ospf: add nhrp multicast for OSPF DMVPN #8153

nhrp, ospf: add nhrp multicast for OSPF DMVPN #8153

Conversation

reubendowle commented Feb 25, 2021

NetDEF-CI commented Feb 25, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Feb 25, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Feb 25, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Feb 25, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Feb 25, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Feb 26, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Jafaral commented Feb 26, 2021

Jafaral commented Feb 26, 2021

donaldsharp commented Feb 26, 2021

reubendowle commented Feb 26, 2021

Jafaral commented Feb 26, 2021 • edited Loading

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Feb 28, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Feb 28, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Feb 28, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

LabN-CI commented Mar 2, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 2, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Apr 5, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 6, 2021

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Jafaral commented Apr 6, 2021

NetDEF-CI commented Apr 6, 2021

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Jafaral left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Apr 8, 2021

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Apr 8, 2021

🚧 Basic BGPD CI results: Partial FAILURE, 3 tests failed

NetDEF-CI commented Apr 8, 2021

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Jafaral commented Apr 8, 2021

NetDEF-CI commented Apr 8, 2021

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

NetDEF-CI commented Feb 25, 2021 •

edited

Loading

LabN-CI commented Feb 25, 2021 •

edited

Loading

NetDEF-CI commented Feb 25, 2021 •

edited

Loading

LabN-CI commented Feb 25, 2021 •

edited

Loading

LabN-CI commented Feb 25, 2021 •

edited

Loading

NetDEF-CI commented Feb 26, 2021 •

edited

Loading

Jafaral commented Feb 26, 2021 •

edited

Loading

LabN-CI commented Feb 28, 2021 •

edited

Loading

NetDEF-CI commented Feb 28, 2021 •

edited

Loading

NetDEF-CI commented Feb 28, 2021 •

edited

Loading

LabN-CI commented Mar 2, 2021 •

edited

Loading

NetDEF-CI commented Mar 2, 2021 •

edited

Loading