Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to add Lidar sensors to settings.json #132

Closed
ctobasti opened this issue Jul 10, 2020 · 3 comments · Fixed by #138
Closed

how to add Lidar sensors to settings.json #132

ctobasti opened this issue Jul 10, 2020 · 3 comments · Fixed by #138
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@ctobasti
Copy link

I tried multiple ways to add additional Lidars to the settings.json file, but none of them were successful.
It would be helpful if you could provide a description of how they should be implemented, as well as adding parameters like HorizontalFOV... that aren`t included in the standard settings.json file, that can be found in the repository.

Also, the Lidar data should be published under the topic /fsds/lidar/LIDAR_NAME. By changing the sensor name of a Lidar (sensor type 6) to anything else than "LidarCustom", the ros bridge prints out the following warning: "No lidar with name LidarCustom exist on vehicle".
Shouldnt the topic name adapt to the Lidar name?

Thanks for the work on the simulation

@SijmenHuizenga
Copy link
Member

SijmenHuizenga commented Jul 11, 2020

Hi! Thanks for trying the simulator!

A detailed description of how to configure the lidar can be found here. You are right, we should include this in the documentation of this project as well. A full example of the lidar configuration is as follows:

              "LidarCustom": { 
                    "SensorType": 6,
                    "NumberOfChannels": 16,
                    "RotationsPerSecond": 10,
                    "PointsPerSecond": 100000,
                    "X": 0, "Y": 0, "Z": -1,
                    "Roll": 0, "Pitch": 0, "Yaw" : 0,
                    "VerticalFOVUpper": -15,
                    "VerticalFOVLower": -25,
                    "HorizontalFOVStart": -20,
                    "HorizontalFOVEnd": 20,
                },

Where NumberOfChannels is the number of lasers.

I will try to replicate the LidarCustom problem later this weekend 👍

May I ask out of curiosity, are you part of any formula student team?

@SijmenHuizenga
Copy link
Member

SijmenHuizenga commented Jul 12, 2020

@ctobasti In #138 the lidar documentation is improved. Would you like to check lidar.md and integration-handbook.md and let me know if this satisfies your question?

@SijmenHuizenga
Copy link
Member

SijmenHuizenga commented Jul 12, 2020

@ctobasti About the No lidar with name LidarCustom exist on vehicle: I can't reproduce this. Can you explain a bit more about your setup? Are you running on Windows or Ubuntu? Are you on a single or on multiple computers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
2 participants