Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to create a LAN game while no network is present quits back to main menu #33

Closed
noodlecollie opened this issue Apr 1, 2019 · 4 comments

Comments

@noodlecollie
Copy link
Contributor

I've been trying to test a multiplayer map in my own fork, and was attempting to do this on my laptop without network connectivity. I only needed to run up a local server with me in it, so actual connectivity was not required.

If I go through the main menu to the multiplayer section and attempt to create a LAN game in this instance, I get the following error:

[17:51:01] Scanning for servers on the local network area...
[17:51:01] Host_Error: NET_SendPacket: Network is unreachable to 100.221.255.191:27015

Because of the host error, I then get taken back to the main menu and am unable to proceed in creating the local server. (Note that I'm running with -dev 5 - I dunno if the same would happen without that option).

My first thoughts on remedying this would be to allow an option to be passed to NET_SendPacket (and the other functions that the local server calls through to) to specify whether failures should be critical. Is this something that would be considered? I could put together a pull request for it if so.

@mittorn
Copy link
Member

mittorn commented Apr 1, 2019

New engine may have many such errors. It was not tested so much in multiplayer. All network errors should be ignored because network may disappear temporary and restore, that will not break UDP connections. Just replace it with error message like in old engine. Yes, you may create PR

@noodlecollie
Copy link
Contributor Author

OK, I've determined that the reason I get kicked back to the main menu is because I started with -toconsole. The console pops up on the host error, and when I hit escape to get out, it takes me back to the main menu.

I'm in the process of replacing the host error with a plain console error, and will create a pull request once it's done.

@noodlecollie
Copy link
Contributor Author

#34

@noodlecollie
Copy link
Contributor Author

Has been merged. Apologies about the commit message format, I'll make sure that's right next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants