Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: introduce COM_ParseFileSafe, add ParseFile test #628

Merged
merged 13 commits into from Oct 8, 2021
Merged

engine: introduce COM_ParseFileSafe, add ParseFile test #628

merged 13 commits into from Oct 8, 2021

Conversation

a1batross
Copy link
Member

@a1batross a1batross commented Sep 30, 2021 •
edited

Tasks to do:

  • Replace every COM_ParseFile occurence with safe version
  • Moved ParseFile into libpublic
  • Add COM_ParseFileSafe to RefAPI, RenderAPI, extended MenuAPI and vgui_support API

May fix #627

@a1batross a1batross force-pushed the parsefile-safe branch 2 times, most recently from acd2a22 to 3b470e2 Compare October 3, 2021 00:37
@a1batross
engine: introduce COM_ParseFileSafe, add tests
54c0197
@a1batross
public: moved COM_ParseFileSafe to libpublic, added optional argument…
38f22a3 
… for length and overflow checking
@a1batross
public: declare unsafe ParseFile as ParseFileLegacy
0d05f60
@a1batross
engine: client: fix ParseFile calls
40f3acb
@a1batross
ref_gl: fix ParseFile calls
c12a441
@a1batross
engine: server: fix ParseFile calls
54618d0
@a1batross
public: ParseFile drops const qualifier, return -1 length on overflow
c64a9ff 
As we usually put allocated data to ParseFile, we don't need const qualifier
@a1batross
engine: common: test ParseFile length return value
8fc0edb
@a1batross
engine: common: fix ParseFile calls
4b80579
@a1batross
engine: add safe ParseFile to menu extended API
6ea6f74
@a1batross
mainui: update
7bab36e
@a1batross
engine: add safe ParseFile to client MobilityAPI
b722668
@a1batross
public: redeclare ParseFile flags to be exactly same as in exported A…
32d5db8 
…PI headers
@a1batross
Copy link
Member Author

a1batross commented Oct 3, 2021 •
edited

Ready for review.
cc @lewa-j @nekonomicon @mittorn @w23 @SNMetamorph

@magisk666
Copy link

what

a1batross referenced this pull request in FWGS/mainui_cpp Oct 7, 2021
@a1batross
Use safe COM_ParseFile
fc78663
@SNMetamorph
Copy link
Member

Looks good to me.

@a1batross a1batross merged commit e5e1570 into master Oct 8, 2021
@a1batross a1batross deleted the parsefile-safe branch July 28, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mittorn mittorn Awaiting requested review from mittorn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COM_ParseFile is unsafe
3 participants
@a1batross @magisk666 @SNMetamorph