Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring scattered "soundtrack.io" strings into app.host + fixing expressJS warnings #185

Merged
merged 1 commit into from
Jan 7, 2016

Conversation

Lucas-C
Copy link
Collaborator

@Lucas-C Lucas-C commented Jan 7, 2016

express-session deprecated undefined resave option; provide resave option at root/soundtrack.io/soundtrack.js:60:10
express-session deprecated undefined saveUninitialized option; provide saveUninitialized option at root/soundtrack.io/soundtrack.js:60:10
express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:767:5
express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:981:5
express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:985:5
express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:986:5
express deprecated req.param(name): Use req.params, req.body, or req.query instead at root/soundtrack.io/soundtrack.js:118:11
express deprecated req.param(name): Use req.params, req.body, or req.query instead at root/soundtrack.io/soundtrack.js:924:15

…expressJS warnings:

    express-session deprecated undefined resave option; provide resave option at root/soundtrack.io/soundtrack.js:60:10
    express-session deprecated undefined saveUninitialized option; provide saveUninitialized option at root/soundtrack.io/soundtrack.js:60:10
    express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:767:5
    express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:981:5
    express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:985:5
    express deprecated app.del: Use app.delete instead at root/soundtrack.io/soundtrack.js:986:5
    express deprecated req.param(name): Use req.params, req.body, or req.query instead at root/soundtrack.io/soundtrack.js:118:11
    express deprecated req.param(name): Use req.params, req.body, or req.query instead at root/soundtrack.io/soundtrack.js:924:15
martindale added a commit that referenced this pull request Jan 7, 2016
Refactoring scattered "soundtrack.io" strings into app.host + fixing expressJS warnings
@martindale martindale merged commit 5360985 into FabricLabs:soundtrack.io Jan 7, 2016
@martindale
Copy link
Member

Nice work!

@Lucas-C
Copy link
Collaborator Author

Lucas-C commented Jan 7, 2016

Thanks :)
But you were slightly too fast : I had forgotten to fix the req.param warning in some files, and I git push --forced a new version, only too late : you had already merged this pull request :(
Could you re-merge the latest version ? Or at least remove that merged commit and I'll reopen a Pull request ?
Sorry for the trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants