Add API for checking if a tag has been replaced #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
reviewed
Jan 18, 2019
src/main/java/net/fabricmc/fabric/api/tag/FabricTagBuilder.java
Outdated
Show resolved
Hide resolved
modmuss50
approved these changes
Jan 21, 2019
|
Asking more if it's a sensible addition, really |
asiekierka
force-pushed
the
tag-replace-check
branch
from
8cd648e
to
05f61ed
Compare
Prospector
added
last call
grondag
approved these changes
Jun 5, 2019
asiekierka
added a commit
that referenced
this pull request
Jun 9, 2019
ThalusA
pushed a commit
to ThalusA/fabric
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is being able to, say, provide vanilla behaviour compatibility in a hook, but also allow overriding it for "total conversion" datapacks.