-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"World" vs "Dimension" vs "Level" and where to use them? #89
Comments
The impression I've gotten is "Level" was the name used in earlier versions, before multiple dimensions got implemented. The main place I recall seeing it was the flashing "Saving level..." text that was removed at some point in Beta, and that was a remnant of some early Alpha version, and it appeared despite doing nothing in SMP. (IIRC, Classic also used the .mclevel extension for save games.) The default name for a save game on a server is
|
net.minecraft.world.Dimension would be awkward, though, on the other hand. |
My preference is WorldSave + World with WorldSave being the collection of Worlds. "Dimension" afaik is just wrong from an English language POV, describing possibly some original intention instead of the actual meaning/implementation these days. The different worlds don't have a particular dimensional meaning in the mathematical sense and with mods adding more "dimensions" that's even closer to just adding more Worlds. Level is commonly used to describe a contiguous region/map, which is the equivalent of a world in Minecraft. The proposed use is orthogonal to that. I didn't go for just save since that's rather ambiguous, so WorldSave seems like a good option. Mojang's own choices are poor, not very feasible to copy. |
Only problem with that is it clashes with |
WorldCollection? :P Alternatively, rename |
Other options for the collection of worlds: Universe, WorldStore |
I don't dislike |
I think the simplest thing would be having saves related to a specific world be labeled Dimension, and use GameSave for saves involving multiple worlds. EDIT: formatting |
We have a few more people in the project now and the old ones may have had some time to think. What is your (current) opinion? |
I don't have a problem with using Dimension. While the word has multiple meanings, it is correct in this context as well. Probably a bit more correct than Universe. |
I guess it's also worth mentioning that "Dimension" is the name the community is using for the different world/dimension types in Vanilla: Minecraft Wiki - Dimensions I feel very weird changing everything |
The community picked "dimension" because dimension 0 goes in "world/region" and dimension 1 goes in "world/DIM1/region". I'm personally for |
Now I think this is fairly clear: |
Currently,
World
is meant for anything regarding single instances of theWorld
class, which is unlikely to change.Level
is being adopted as the term used for a single save - confusingly also called "World" in the game (such as "Create New World"), though sometimes "Level" in the code (like "preparing level ...").Previously some of our classes were using "Dimension" to describe an instance of a world (usually which ID -
dimensionId
) or its type (Overworld / Nether / End -DimensionType
), though I've done some changes to get rid of the mention of "dimension" completely.I'm not sure this is the correct way to go about it. We should retain the name "Dimension" for something, though I'm not entirely sure what to use it for.
The text was updated successfully, but these errors were encountered: