Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD uses branch of reactiveops/charts rather than master #154

Closed
rbren opened this issue Jun 22, 2019 · 4 comments
Closed

CI/CD uses branch of reactiveops/charts rather than master #154

rbren opened this issue Jun 22, 2019 · 4 comments

Comments

@rbren
Copy link
Contributor

rbren commented Jun 22, 2019

If a fix is merged into the master branch, but not the polaris-latest branch, it won't make it into polaris releases.
@rbren rbren mentioned this issue Jun 22, 2019
Closed
@endzyme
Copy link
Contributor

endzyme commented Jun 23, 2019

Would it be more prudent to tag a commit as Polaris-latest instead of actively sync a branch?

@endzyme
Copy link
Contributor

endzyme commented Jun 23, 2019

Actually, by having a branch that isn't master, isn't that indicating that master may not be releasable? Let's connect on this on Monday, I'm interested to understand the pros and cons of these methods and how automated each one can be for releases. :D

@endzyme
Copy link
Contributor

endzyme commented Jul 2, 2019

I think this is resolved with #156

@endzyme endzyme closed this as completed Jul 2, 2019
@endzyme
Copy link
Contributor

endzyme commented Jul 2, 2019

TL;DR - the process for managing both helm chart and local repo deploy.yml changes is outlined in CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endzyme @rbren