Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player time-outs on launching multiplayer campaign savefile #4183

Closed
1 task done
FLundin opened this issue Oct 31, 2020 · 3 comments
Closed
1 task done

Player time-outs on launching multiplayer campaign savefile #4183

FLundin opened this issue Oct 31, 2020 · 3 comments
Assignees
Labels
Bug Something isn't working Code Programming task Networking Issue related to multiplayer or networking

Comments

@FLundin
Copy link

FLundin commented Oct 31, 2020

  • I have searched the issue tracker to check if the issue has already been reported.

Description
When selecting a previous campaign savefile to load, up on loading players fail to load and gets kicked off the server.

Steps To Reproduce
Its hard to determine the factors in this but, me and my friends speculate it have to do with:

  1. Host have a bad upline
  2. clients have a bad connection/downline from the host
  3. Large save files
  4. Savefiles containing more than one owned sub
  5. amount of players downloading the savefile form the server the same time

Version
since you published the new campaign map until v0.10.6.2 Win 10

Additional information
Back before the new campaign map update, you had a system that allowed players to preload the savefile and players, depending on their download speed and your upload speed in conjunction with the size of the savefile allowed you to wait for them to load the file completely (using the "ready" button to signal that they were done) before launching the game. This new system have cause issues where i had to abandon campaigns multiple times with friends because players could not all join in the same time.

Solution to this could be to:

  1. bring back the preloading of savefiles in the lobby
  2. Allow the players to see all players loading % (maybe like this game https://i.imgur.com/vXIQA7j.jpg) and have a system that do not launch untill all is ready or have a host controlled start button.
  3. Make the game and clients/server host less sensitive to long loading times.
@EdusFF EdusFF added Bug Something isn't working Code Programming task Networking Issue related to multiplayer or networking labels Nov 2, 2020
@codethenpizza
Copy link

Have same on version 0.11.0.9 (mac os)

@Regalis11
Copy link
Collaborator

Regalis11 commented May 5, 2021

Possibly a duplicate of #5702. It's hard to say for sure without knowing what kind of an error message the clients get when they disconnect, but if it was "Error while starting the round (did not receive STARTGAMEFINALIZE message from the server). Stopping the round...", this should now be fixed.

(Link to the fix on our private repo https://github.com/Regalis11/Barotrauma-development/commit/34df975378b0a4371edd9c9656da05e7735c05e5)

@Rokvach
Copy link
Collaborator

Rokvach commented May 25, 2021

Tested, there hasn't been any sightings of this happening during the Unstable period, seems to be working correctly. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task Networking Issue related to multiplayer or networking
Projects
None yet
Development

No branches or pull requests

5 participants