Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithNonVoidReturnType rules describe themselves as "any call" #970

Closed
blairconrad opened this issue Jan 17, 2017 · 2 comments
Closed

WithNonVoidReturnType rules describe themselves as "any call" #970

blairconrad opened this issue Jan 17, 2017 · 2 comments
Assignees
@blairconrad
Labels
🪲 bug
Milestone
2.3.3

Comments

@blairconrad
Copy link
Member

As @thomaslevesque noted in #967 (review):

Also, I just noticed that ApplicableToAllNonVoidReturnTypes is not taken into account in
DescriptionOfValidCall. It's not related to the original issue, but it's a good occasion to fix it as well.
@blairconrad blairconrad added this to the 2.3.3 milestone Jan 17, 2017
@blairconrad blairconrad self-assigned this Jan 17, 2017
blairconrad added a commit to blairconrad/FakeItEasy that referenced this issue Jan 17, 2017
@blairconrad
Provide description for WithNonVoidReturnType call rule
36a2d71 
Fixes FakeItEasy#970.
blairconrad added a commit to blairconrad/FakeItEasy that referenced this issue Jan 17, 2017
@blairconrad
Provide description for WithNonVoidReturnType call rule
a4613b7 
Fixes FakeItEasy#970.
@blairconrad
Copy link
Member Author

Fixed in #971.

@blairconrad
Copy link
Member Author

blairconrad commented Jan 18, 2017 •
edited

This issue has been released in FakeItEasy 2.3.3:
https://github.com/FakeItEasy/FakeItEasy/releases/tag/2.3.3

blairconrad added a commit to blairconrad/FakeItEasy that referenced this issue Jan 18, 2017
@blairconrad
Merge branch 'with-non-void-return-type-matches-void]' into merge-2.3.3
bf456fd 
Includes fixes for FakeItEasy#966 and FakeItEasy#970

Skipped:
	src/CommonAssemblyInfo.cs

Conflicts:
	tests/FakeItEasy.IntegrationTests.VB/RefArgumentConstraintTests.vb
	tests/FakeItEasy.Specs/AnyCallConfigurationSpecs.cs
blairconrad added a commit to blairconrad/FakeItEasy that referenced this issue Jan 18, 2017
@blairconrad
Merge 2.3.3 changes
f3c3914 
Merge 7b210ca, originally merged to support-2 as FakeItEasy#971.
Contains fixes for FakeItEasy#966 and FakeItEasy#970.
@blairconrad blairconrad mentioned this issue Jan 18, 2017
Merged
This was referenced Feb 18, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blairconrad blairconrad

Labels
🪲 bug
Projects
None yet
Milestone
2.3.3
Development

No branches or pull requests
1 participant
@blairconrad