-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Merge 2.3.3 #972
[WIP] Merge 2.3.3 #972
Conversation
Fix bug for constraint on ref or out argument (cherry picked from commit 8e8817f)
Backport fix for FakeItEasy#899 to 2.x
Set version to 2.3.2
…desktop Have AppVeyor just build .NET Desktop version
Set version to 2.3.3
…rn-type-matches-void] Keep WithNonVoidReturnType from matching void
Skipped src/CommonAssemblyInfo.cs.
Sadly, we're picking up changes from even before dbb80f3. This may not be the way to go. |
With our current branching model, I don't see any benefit in merging like this rather than just cherry-picking the commits we need. This PR contains many commits that have no reason to be there (well, I'm sure there's a good technical reason, but conceptually, we just want to port a specific fix to master, the other commits are just noise). There will always be changes on |
I concur. I know @adamralph is very keen on being able to follow the merge lines to find the hotfix changes, but I'm content with a cherry-pick. Thanks! |
And we should be able to when we switch to gitflow ;) |
One possible way to merge the recent changes for 2.3.3.
I created a merge branch (merge-2.3.3) and merged 2.3.3 into it.
This is the result.
There was version conflict, so I excluded CommonAssemblyInfo.cs.
If we don't like this approach, I could cherry-pick 7b210ca instead.
Connects to #966
Connects to #970