Create ProxyOptions only when required #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
previously approved these changes
Oct 6, 2018
blairconrad
force-pushed
the
create-proxyoptions-at-need
branch
from
1af0552
to
0c5f57a
Compare
|
Thank you, @thomaslevesque. Squashed. |
thomaslevesque
approved these changes
Oct 6, 2018
|
This change has been released in FakeItEasy 5.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed earlier. There may be a small improvement in the time required to create fakes. Certainly we'll make fewer objects in what I believe to be the most common case - where there's no fake options builder used to create a fake.
I profiled:
Tell me what you think.
I made two commits because I didn't want the rename to confuse the diffs.