-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show messages only for build exceptions #1529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamralph! Since I merged your other PR, could you please rebase this one?
I very much like the effect, @adamralph. I'm glad you brought the PR though, since I find the new syntax to be a little opaque. But then again, where was I to comment when you were developing it? |
Rebased. It's only a beta feature so I'm still open to suggestions. 😃 BTW - there is another overload which takes a RunTargetsAndExit(args, exceptionMessageOnly: new[] { typeof(CommandException) }); It has the advantage of being able to write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamralph!
Thanks, @adamralph. I suppose if there was a one-type overload that took an |
Maybe a predicate parameter would make things clearer |
@thomaslevesque I assume you mean like this? RunTargetsAndExit(args, messageOnly: ex => ex is CommandException); I really like that! I'll sleep on it, but I think that may be a much better way to do it. |
WIP PR: adamralph/bullseye#182 |
Yes! |
This change has been released in FakeItEasy 5.0.0. |
Since each target is a one-liner which calls SimpleExec, the stack traces are useless. This changes this:
to this: