Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overridden Equals on wrapping Fake causes call to be forwarded to wrapped object #1849

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

blairconrad
Copy link
Member

No description provided.

@blairconrad
Copy link
Member Author

Found while investigating performance improvements around resolving Object methods. InterceptedFakeObjectCallExtensions didn't look right.

@blairconrad blairconrad changed the title [WIP] Overridden Equals on wrapping Fake causes call to be forwarded to wrapped object Overridden Equals on wrapping Fake causes call to be forwarded to wrapped object Jun 26, 2021
Copy link
Member

@thomaslevesque thomaslevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blairconrad, looks fine to me!

@thomaslevesque thomaslevesque merged commit b141bb1 into FakeItEasy:master Jun 26, 2021
@blairconrad blairconrad added this to the vNext milestone Jun 26, 2021
@blairconrad blairconrad deleted the wrap-equals branch June 26, 2021 18:31
@afakebot
Copy link

afakebot commented Sep 1, 2021

This change has been released as part of FakeItEasy 7.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants