StrictFakeOptions.Allow* do not apply to overridden Object methods #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairconrad
changed the title
|
Currently builds on #1849. Only the 3 latest commits properly belong to this PR. |
blairconrad
commented
Jun 26, 2021
| @@ -58,6 +58,26 @@ public interface IMyInterface | |||
| .x(() => exception.Should().BeAnExceptionOfType<ExpectationException>()); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
None of the new tests initially passed.
thomaslevesque
approved these changes
Jun 26, 2021
There was a problem hiding this comment.
Looks fine to me. And it looks like I had made the same mistake again with IsSameMethodAs/HasSameBaseMethodAs. Thanks @blairconrad!
|
Should be merged automatically after you rebase |
blairconrad
changed the title
|
Whoops! I foolishly changed the title before I rebased. Why? I don't know. I was here and not thinking and it automerged. We got an ugly graph. Sorry about that. Also, thanks for the review and auto-merge! |
|
This change has been released as part of FakeItEasy 7.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.