make sure there's a record to emit

[swilly22]

Fixes #621

[coderabbitai]

Walkthrough

This update enhances the stability of the system by refining how operations handle and manipulate data structures, particularly focusing on record handling and memory management during CREATE operations in graphs. These changes are critical for preventing crashes and ensuring smoother operations.

Changes

File	Change Summary
src/execution_plan/ops/op_create.c	Enhanced safety checks and memory handling in record operations.
tests/flow/test_call_subquery.py	Added a test for creating entities within CALL subqueries.

Assessment against linked issues

Objective	Addressed	Explanation
Crash when executing nested operations involving CREATE, DELETE, and relationships [#621]	✅
Address crashes related to CREATE operations and subsequent node handling in RedisGraph	✅
Ensure proper initialization and cleanup of data structures to prevent access violations	✅

Possibly related issues

• Crash due to untrue assertion Graph_GetNode == 1 #422: The changes might prevent crashes by handling node creation and deletion more robustly.
• Query crashes rg in ExecutionPlan_Clone #438: If the crash is related to handling of CREATE operations, this PR could potentially address it.
• Crash due to untrue assertion i < n #428: The update in initialization might indirectly stabilize the operations prone to assertion failures.

Poem

🐇✨
In the code where nodes do weave,
A rabbit hopped, fixes to achieve.
No more crashes, smooth runs the graph,
With each line, a safer path.
Hop, hop, hooray, let's celebrate,
For stable queries, we do create! 🌟
🐇💻

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between b613a26 and 457edea.

Files selected for processing (2)

• src/execution_plan/ops/op_create.c (3 hunks)
• tests/flow/test_call_subquery.py (1 hunks)

Additional comments not posted (3)

src/execution_plan/ops/op_create.c (3)

136-137: The modification to check if op->records has elements before popping is a good safeguard against null dereferences.

---

136-137: Initializing op->records as an array instead of NULL is a prudent change that enhances the robustness of record handling.

---

211-211: Correcting the loop to start at index 0 in CreateFree ensures that all records are properly freed, preventing memory leaks.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

The test description does not accurately reflect the query's behavior.

- # 2. a Match outside the sub query will pull as many records as it can
- #    untill the sub query is depleted
+ # 2. Match the created node outside the sub query

The description suggests that the test will match the node created in the CALL subquery outside of it, but the actual query does not attempt to match this node. Please update the query or the description to align them correctly.

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	def test34_create_within_call(self):
	# The query will:
	# 1. Create an entity within a CALL sub query
	# 2. a Match outside the sub query will pull as many records as it can
	# untill the sub query is depleted
	q = """CALL {
	CREATE ()
	RETURN 0 AS X
	}
	MATCH ()--()
	RETURN 0"""
	res = self.graph.query(q)
	self.env.assertEquals(res.nodes_created, 1)
	self.env.assertEquals(len(res.result_set), 0)
	def test34_create_within_call(self):
	# The query will:
	# 1. Create an entity within a CALL sub query
	# 2. Match the created node outside the sub query
	q = """CALL {
	CREATE ()
	RETURN 0 AS X
	}
	MATCH ()--()
	RETURN 0"""
	res = self.graph.query(q)
	self.env.assertEquals(res.nodes_created, 1)
	self.env.assertEquals(len(res.result_set), 0)