Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.10 #679

Merged
merged 19 commits into from
May 13, 2024
Merged

4.0.10 #679

merged 19 commits into from
May 13, 2024

Conversation

swilly22
Copy link
Contributor

No description provided.

dudizimber and others added 19 commits March 29, 2024 15:21
* add instructions to run browser UI

* set hostname to 0.0.0.0
* fix crash in rewrite call subquery

* simplified test query

---------

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* fix merge init

* remove unused function, simplified branch assignment logic

* clean

---------

Co-authored-by: Roi Lipman <roilipman@gmail.com>
* persist unwind record

* deep clone base record
* persist unwind record

* disable GraphBLAS JIT
* update RediSearch submodule

* bump RediSearch version

* updated redis module api header file
* Add objective to README

* Update wordlist.txt

---------

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* wip runtime optimization

* fix leak

* fix node by label scan

* fix leak

* fix leak

* address review

* add tests

* address review

* review

* review

* review

* add memory hook to roaring bitmap

* introduce bitmap range

---------

Co-authored-by: Roi Lipman <roilipman@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* add coverage build

* rename

* fix

* fix cache

* install redis in coverage
* ref count record

* nullify record on deletion

* handle record ref count within execution plan return record

* address PR comments

* remove head & tail calls to persist

* trying to simplify and make value passing safer and simpler

* free aggregated group once yield

* removed Record_PersistScalars

* removed override flag

* remove extra persists

* group no longer holds a keys array

* only persists keys which are not graph entities

* allow for record cloning from different execution plans
@swilly22 swilly22 requested a review from AviAvni May 13, 2024 18:25
Copy link

coderabbitai bot commented May 13, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 87.55187% with 30 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (4.0@b7979fd). Click here to learn what that means.

Files Patch % Lines
src/execution_plan/ops/op_sort.c 16.66% 5 Missing ⚠️
src/execution_plan/ops/op_expand_into.c 42.85% 4 Missing ⚠️
src/execution_plan/ops/op_apply_multiplexer.c 71.42% 2 Missing ⚠️
src/execution_plan/ops/op_argument.c 0.00% 2 Missing ⚠️
src/execution_plan/ops/op_call_subquery.c 71.42% 2 Missing ⚠️
src/execution_plan/ops/op_merge.c 33.33% 2 Missing ⚠️
src/execution_plan/ops/op_node_by_id_seek.c 50.00% 2 Missing ⚠️
src/execution_plan/ops/op_node_by_label_scan.c 66.66% 2 Missing ⚠️
src/execution_plan/ops/op_semi_apply.c 66.66% 2 Missing ⚠️
src/execution_plan/ops/op_all_node_scan.c 66.66% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@          Coverage Diff           @@
##             4.0     #679   +/-   ##
======================================
  Coverage       ?   81.03%           
======================================
  Files          ?      313           
  Lines          ?    31855           
  Branches       ?     5120           
======================================
  Hits           ?    25815           
  Misses         ?     5208           
  Partials       ?      832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swilly22 swilly22 linked an issue May 13, 2024 that may be closed by this pull request
@swilly22 swilly22 merged commit c83fbf9 into 4.0 May 13, 2024
14 of 16 checks passed
@swilly22 swilly22 deleted the 4.0.10 branch May 13, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.10 release
4 participants