Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Index, do not escape TAG field #667

Merged
merged 1 commit into from
May 1, 2024
Merged

Update Index, do not escape TAG field #667

merged 1 commit into from
May 1, 2024

Conversation

swilly22
Copy link
Contributor

@swilly22 swilly22 commented May 1, 2024

Fix: #664

@swilly22 swilly22 added the bug Something isn't working label May 1, 2024
@swilly22 swilly22 requested a review from AviAvni May 1, 2024 08:56
@swilly22 swilly22 self-assigned this May 1, 2024
Copy link

coderabbitai bot commented May 1, 2024

Walkthrough

This update primarily involves a change in the commit hash for the RediSearch subproject and the addition of a new test method in test_index_scans.py to verify the behavior of a range index on unescaped strings in a graph database. The change aims to enhance testing capabilities and ensure robustness in handling complex string properties.

Changes

File Change Summary
deps/RediSearch Updated subproject commit hash
tests/.../test_index_scans.py Added new test method test_25_unescaped_string

Assessment against linked issues

Objective Addressed Explanation
Crash while enforcing unique constraint on string property of nodes (#664) The changes do not address the crash issue related to unique constraint enforcement.
Reproduction steps involving creating labeled nodes with specific data triggering the issue (#664) No changes related to handling or modifying unique constraints or their replication were made.

Possibly related issues

🐰✨
A hop, a skip, a code deploy,
In the burrow, we refine and enjoy.
With each commit, we aim to fix,
Bugs and glitches, with clever tricks!
Here's to the changes, big and small,
May our database stand tall! 🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7e5c58f and d89e12f.
Files selected for processing (2)
  • deps/RediSearch (1 hunks)
  • tests/flow/test_index_scans.py (1 hunks)
Files skipped from review due to trivial changes (1)
  • deps/RediSearch
Additional Context Used
Ruff (28)
tests/flow/test_index_scans.py (28)

1-1: from common import * used; unable to detect undefined names


2-2: from index_utils import * used; unable to detect undefined names


4-4: sys may be undefined, or defined from star imports


4-4: os may be undefined, or defined from star imports


4-4: os may be undefined, or defined from star imports


5-5: Module level import not at top of file


12-12: Env may be undefined, or defined from star imports


26-26: wait_for_indices_to_sync may be undefined, or defined from star imports


63-63: create_node_range_index may be undefined, or defined from star imports


156-156: create_node_range_index may be undefined, or defined from star imports


215-215: create_node_range_index may be undefined, or defined from star imports


228-228: create_node_range_index may be undefined, or defined from star imports


291-291: create_node_range_index may be undefined, or defined from star imports


386-386: Graph may be undefined, or defined from star imports


389-389: create_node_fulltext_index may be undefined, or defined from star imports


562-562: create_node_range_index may be undefined, or defined from star imports


570-570: create_node_range_index may be undefined, or defined from star imports


571-571: create_node_range_index may be undefined, or defined from star imports


616-616: create_node_range_index may be undefined, or defined from star imports


618-618: create_node_fulltext_index may be undefined, or defined from star imports


634-634: Node may be undefined, or defined from star imports


644-644: create_node_range_index may be undefined, or defined from star imports


653-653: redis may be undefined, or defined from star imports


657-657: Graph may be undefined, or defined from star imports


671-671: create_node_range_index may be undefined, or defined from star imports


693-693: create_node_range_index may be undefined, or defined from star imports


707-707: create_node_range_index may be undefined, or defined from star imports


708-708: create_node_fulltext_index may be undefined, or defined from star imports

Additional comments not posted (1)
tests/flow/test_index_scans.py (1)

731-744: The new test method test_25_unescaped_string correctly implements the intended test logic for handling unescaped strings in index scans.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
tests/flow/test_index_scans.py (1)

Line range hint 1-1: Consider replacing star imports with specific imports to improve code clarity and maintainability. For example, replace from common import * with specific imports like from common import Env, Node.

@swilly22 swilly22 merged commit 3f95149 into master May 1, 2024
18 checks passed
@swilly22 swilly22 deleted the tag-escaping branch May 1, 2024 10:30
swilly22 added a commit that referenced this pull request May 13, 2024
* 600 add browser usage for the docker image (#601)

* add instructions to run browser UI

* set hostname to 0.0.0.0

* fix crash in rewrite call subquery (#604)

* fix crash in rewrite call subquery

* simplified test query

---------

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* use debug assert in rust (#606)

* fix merge init (#609)

* fix merge init

* remove unused function, simplified branch assignment logic

* clean

---------

Co-authored-by: Roi Lipman <roilipman@gmail.com>

* Unwind persist (#613)

* persist unwind record

* deep clone base record

* Disable jit (#612)

* persist unwind record

* disable GraphBLAS JIT

* Update module api (#617)

* update RediSearch submodule

* bump RediSearch version

* updated redis module api header file

* make sure there's a record to emit (#623)

* update RediSearch (#640)

* Fix #634 Add Cloud link to README.md (#635)

* fix #645 Add objective to README (#646)

* Add objective to README

* Update wordlist.txt

---------

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* fix union validation with call subquery (#648)

* Seek by id runtime optimization (#643)

* wip runtime optimization

* fix leak

* fix node by label scan

* fix leak

* fix leak

* address review

* add tests

* address review

* review

* review

* review

* add memory hook to roaring bitmap

* introduce bitmap range

---------

Co-authored-by: Roi Lipman <roilipman@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* zero dim vector save/load (#654)

* update redisearch, do not escape TAG field (#667)

* Code coverage (#674)

* add coverage build

* rename

* fix

* fix cache

* install redis in coverage

* ignore some path in code coverage (#678)

* Ref count record (#663)

* ref count record

* nullify record on deletion

* handle record ref count within execution plan return record

* address PR comments

* remove head & tail calls to persist

* trying to simplify and make value passing safer and simpler

* free aggregated group once yield

* removed Record_PersistScalars

* removed override flag

* remove extra persists

* group no longer holds a keys array

* only persists keys which are not graph entities

* allow for record cloning from different execution plans

---------

Co-authored-by: Dudi <16744955+dudizimber@users.noreply.github.com>
Co-authored-by: Avi Avni <avi.avni@gmail.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash while enforcing unique constraint on string property of nodes.
2 participants