Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included scripts are added to <head> and bundle #43

Open
djgrant opened this issue Jul 2, 2015 · 1 comment
Open

Included scripts are added to <head> and bundle #43

djgrant opened this issue Jul 2, 2015 · 1 comment

Comments

@djgrant
Copy link

djgrant commented Jul 2, 2015

Results in external.js being referenced in the document and added to user~scene.bundle.js:

FamousFramework.scene('user:scene', {
})
.config({
    includes: [
        'external.js'
    ]
});
@matthewtoast
Copy link
Contributor

Another great catch. We should only be inlining the external.js and not including it in the head. (This is related to a bit of vestigial code that should be removed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewtoast @djgrant