Test necessary imports #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gymnasium/envs/external/gym_env.py
# Conflicts: # tests/envs/test_envs.py
# Conflicts: # tests/envs/test_pprint_registry.py
# Conflicts: # setup.py
# Conflicts: # gymnasium/wrappers/compatibility.py # setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inspired by
Shimmywhere we have CI for each of the other optional dependencies to ensure that there are not optional dependencies that are actually required.Issues like this have happened before with moviepy and other modules for wrappers often.
Therefore, this PR adds necessary tests for gymnasium (optional tests already existed as we installed
gymnasium[all])This is done through splitting the testing and optional installs to allow
gymnasium[all, testing]for all modules andgymnasium[testing]for only the necessary modules for testing@RedTachyon This PR is dependent on #125 so review that first