Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulding manylinux wheels using cibuildwheel #73

Merged
merged 12 commits into from
Oct 11, 2023

Conversation

mwydmuch
Copy link
Contributor

@mwydmuch mwydmuch commented Oct 9, 2023

This PR:

  • replace the old build-publish-linux.yml workflow with new one that uses cibuildwheel to build manylinux wheels compatible with manylixnu_2_28 policy (for compliance, check here) for Python 3.8-3.10.
  • it adds manual tests in tests\test_cibuildwheel directory.
  • it does minimal modifications to the code, setup.py and CMakeLists.txt to improve compatibility and ensure correct compilation using manylinux images.

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Marek, is there anything left to do or should I merge?

@mwydmuch
Copy link
Contributor Author

Thank you! If you don't have any comments, then I think it can be merged :) I believe further work on compatibility with Python 3.11, Linux ARM, macOS Intel, and M1/M2, should be separate PRs.

@pseudo-rnd-thoughts
Copy link
Member

Thank you! If you don't have any comments, then I think it can be merged :) I believe further work on compatibility with Python 3.11, Linux ARM, macOS Intel, and M1/M2, should be separate PRs.

Yes agreed, I think that is a good idea

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit cec42fc into Farama-Foundation:master Oct 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants