Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv3: Remove UIkit and revamp pages with FastForward CSS #964

Merged
merged 16 commits into from
May 6, 2023

Conversation

NotAProton
Copy link
Member

@NotAProton NotAProton commented Apr 20, 2023

To test before navigate pages, click on these links with the extension installed:
crowd-bypassed: https://fastforward.team/bypassed?target=https%3A%2F%2Fgoogle.com&crowd=true
before-navigate: https://fastforward.team/bypassed?target=https%3A%2F%2Fgoogle.com

Description:

  • Removed UIkit, now the extension uses no external libraries
  • Rewrote options, before-navigate and crowd-bypassed pages using css from the FastForward website
  • Copied over CONTRIBUTORS.md from main

Checklist:

  • I made sure there are no unnecessary changes in the code*
  • Tested on Chromium- Chrome 112 Windows
  • Tested on Firefox

@NotAProton NotAProton requested a review from AliahX April 20, 2023 07:59
@NotAProton NotAProton changed the title Remove uikit WIP: Remove uikit Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Apr 20, 2023

Download the artifacts for this pull request:

@NotAProton NotAProton marked this pull request as draft April 20, 2023 08:00
@NotAProton NotAProton changed the title WIP: Remove uikit WIP: Mv3: Remove uikit Apr 20, 2023
src/html/base.js Fixed Show resolved Hide resolved
@AliahX
Copy link
Member

AliahX commented Apr 20, 2023

i'll check it out in a minute, just working on another pr rn

AliahX and others added 8 commits April 20, 2023 23:20
Remove save whitelist button functionality and replace it with on input for the textarea, which gets a red border when it has invalid text.
Fix formatting. Update logo to match website logo. Move version text to bottom of screen.  Remove save whitelist button
Shut up bot
@AliahX
Copy link
Member

AliahX commented Apr 26, 2023

This branch is missing the CONTRIBUTORS.md file that is linked to by the extension.

@NotAProton
Copy link
Member Author

NotAProton commented Apr 30, 2023

Resolved

what about mobile responsiveness?
chrome-extension___ambaeodiomeedcpomkgkkobenfgddedg_html_options html

also move navbar back to top if window is resized
Co-authored-by: AliahX <40045439+AliahX@users.noreply.github.com>
@AliahX
Copy link
Member

AliahX commented May 1, 2023

I think i have a solution maybe. Do we need the changelog faq and contributors buttons on mobile?

@NotAProton
Copy link
Member Author

I think only 3 people ever clicked on them lol, we can just push them to the bottom

@NotAProton NotAProton marked this pull request as ready for review May 1, 2023 11:03
@NotAProton NotAProton changed the title WIP: Mv3: Remove uikit Mv3: Remove UIkit and revamp pages with FastForward CSS May 1, 2023
CONTRIBUTORS.md Outdated Show resolved Hide resolved
@NotAProton NotAProton requested a review from 0xc60f May 4, 2023 08:51
@NotAProton NotAProton merged commit 3a356bd into FastForwardTeam:manifest-v3 May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants