Allow primitive array deserializer to be captured by DeserializerModifier
#4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pjfanning
reviewed
Nov 25, 2023
| package com.fasterxml.jackson.databind.deser; | ||
|
|
||
| import static com.fasterxml.jackson.databind.BaseMapTest.jsonMapperBuilder; | ||
| import static junit.framework.TestCase.assertEquals; |
There was a problem hiding this comment.
Can use you use org.junit.Asserts?
There was a problem hiding this comment.
or even use the Jupiter asserts, but put the params in the right order - the ones expected by the Jupiter (actual, expected)
There was a problem hiding this comment.
Ah, thank you for pointing out! Totally missed that.
There was a problem hiding this comment.
I was confused, so I looked into org.Junit.Assert.assertEquals(). It actually seems to be declared in exepected, actual order, so current format should be reasonable 🤔. If( not, could you lemme know if there is another Assert?
| @@ -1348,13 +1348,15 @@ public JsonDeserializer<?> createArrayDeserializer(DeserializationContext ctxt, | |||
| if (contentDeser == null) { | |||
| Class<?> raw = elemType.getRawClass(); | |||
| if (elemType.isPrimitive()) { | |||
| return PrimitiveArrayDeserializers.forType(raw); | |||
| deser = PrimitiveArrayDeserializers.forType(raw); | |||
| } | |||
| if (raw == String.class) { | |||
There was a problem hiding this comment.
-> else if? I can change that actually. n/m
cowtowncoder
approved these changes
Nov 26, 2023
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Dec 27, 2023
### What changes were proposed in this pull request? This pr aims to upgrade jackson from 2.16.0 to 2.16.1 ### Why are the changes needed? The new version bring some fix: - [#4200](FasterXML/jackson-databind#4200): JsonSetter(contentNulls = FAIL) is ignored in delegating JsonCreator argument - [#4216](FasterXML/jackson-databind#4216): Primitive array deserializer not being captured by DeserializerModifier - [#4219](FasterXML/jackson-databind#4219): JsonNode.findValues() and findParents() missing expected values in 2.16.0 The full release notes as follows: - https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44494 from LuciferYang/SPARK-46508. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4216