-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliced ByteBuffer's Array Offset not respected #1662 #2144
Conversation
Shouldn't proposed changes be synchronized with the following code for non-array based byte buffers?
|
|
Any chance to get this in 2.9.8? Would like to have this asap available. |
Right now I am swamped with work and have unfortunately little time to work on Jackson. But we'll see. I can't promise any specific date at this point, and it is unlikely 2.9.8 specifically would be released during October. I am bit unsure if the change is safe enough to include in 2.9, however, and was considering it to go in 2.10.0 instead to reduce any risk of regression. |
There are only two code paths leading to the change line:
For 1) there was already a unit tests and for 2) I created one that, if you remove my one line of change, will fail. So IMHO there's a negligible risk by publishing this change. |
@marc-christian-schulze Ok. |
Would merge but Github is having... issues... it seems :-( |
Hmmh. Ok, didn't notice it's for master. Need to manually merge. |
Fix for #1662