Skip to content
This repository

Fixed hideous rendering of consolas bold (and possibly other bold cleartype fonts) #9

Closed
wants to merge 1 commit into from

3 participants

robotslave Chris West yumeyao
Chris West
Owner

I can't reproduce the issue you're referring to; the patch seems to make no difference to the rendering of 13-pt Consolas for me? Seven sp1 x64.

Unpatched and patched PuTTY rendering 13pt Consolas

robotslave
robotslave
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
f024f9c
Chris West FauxFaux closed this
Chris West
Owner

Oh my eyes, that's horrific.

robotslave
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
22fe440
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
0030b0a
Chris West FauxFaux referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Chris West FauxFaux referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Chris West FauxFaux referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
5a93e29
Chris West FauxFaux referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Chris West FauxFaux referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
55f6a13
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
b368b53
yumeyao
yumeyao commented

Let me add my comments:

An updated commit is here
#39

Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
8189ac0
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
09ee8fb
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
c0c2cad
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
14feee1
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
16613ff
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
f5956de
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
bc81ef9
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
d8d01b4
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
1bed07e
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
9c7ce97
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
da67e2d
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
ed67bee
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
9e475dc
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
b62619d
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
1b4e01c
Chris West FauxFaux referenced this pull request from a commit
robotslave gh-9: Fixed hideous rendering of consolas bold.
For detailed explanation, see here:
http://stackoverflow.com/questions/2520610/detecting-cleartype-optimized-fonts

To reproduce, you need Configuration -> Window -> Colours -> Bolded text is a different colour disabled
8a5cac8
Philip Moore FireEgl referenced this pull request from a commit in FireEgl/FuTTY
Philip Moore Revert "gh-9: Fixed hideous rendering of consolas bold."
This reverts commit 09ee8fb.

This change isn't necessary, upstream (PuTTY) fixed the problem in another way?
0f47e50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 4 additions and 3 deletions. Show diff stats Hide diff stats

  1. 7  windows/window.c
7  windows/window.c
@@ -1621,6 +1621,10 @@ static void init_fonts(int pick_width, int pick_height)
1621 1621
 
1622 1622
     f(FONT_NORMAL, cfg.font.charset, fw_dontcare, FALSE);
1623 1623
 
  1624
+	if (bold_mode == BOLD_FONT) {
  1625
+		f(FONT_BOLD, cfg.font.charset, fw_bold, FALSE);
  1626
+    }
  1627
+
1624 1628
     SelectObject(hdc, fonts[FONT_NORMAL]);
1625 1629
     GetTextMetrics(hdc, &tm);
1626 1630
 
@@ -1712,9 +1716,6 @@ static void init_fonts(int pick_width, int pick_height)
1712 1716
 	}
1713 1717
     }
1714 1718
 
1715  
-    if (bold_mode == BOLD_FONT) {
1716  
-	f(FONT_BOLD, cfg.font.charset, fw_bold, FALSE);
1717  
-    }
1718 1719
 #undef f
1719 1720
 
1720 1721
     descent = tm.tmAscent + 1;
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.