Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routes/pdf): limit outputEncoding qs params to poppler charsets #1353

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Mar 23, 2023

Charsets like 'utf-32' are not supported and throws errors, so limit charsets to only Poppler supported ones.

@Fdawgs Fdawgs self-assigned this Mar 23, 2023
@Fdawgs Fdawgs changed the title fix(routes/pdf/txt): limit encodings to poppler supported ones only fix(routes/pdf/txt): limit charsets to poppler supported ones only Mar 23, 2023
@coveralls
Copy link

coveralls commented Mar 23, 2023

Pull Request Test Coverage Report for Build 4508993540

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4508977435: 0.0%
Covered Lines: 1118
Relevant Lines: 1118

💛 - Coveralls

@Fdawgs Fdawgs changed the title fix(routes/pdf/txt): limit charsets to poppler supported ones only fix(routes/pdf): limit outputEncoding qs params to poppler charsets Mar 23, 2023
@Fdawgs Fdawgs merged commit 92500d6 into main Mar 24, 2023
@Fdawgs Fdawgs deleted the fix/routes-pdf-encoding branch March 24, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants