New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(plugins): replace `RegExp.test()` with `String.includes()` #1418

Merged

Fdawgs merged 1 commit into main from perf/includes

Apr 17, 2023

Owner

Fdawgs commented Apr 17, 2023

.includes() is way faster than .test(), see https://github.com/RafaelGSS/nodejs-bench-operations/blob/main/RESULTS-v18.md#string-searching

Fdawgs self-assigned this


          perf(plugins): replace RegExp.test() with String.includes()

83d9558

Fdawgs force-pushed the perf/includes branch from 531f063 to 83d9558 Compare

April 17, 2023 10:34

coveralls commented Apr 17, 2023

Pull Request Test Coverage Report for Build 4720189089

0 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 4677293015:	0.0%
Covered Lines:	573
Relevant Lines:	573

💛 - Coveralls

coveralls commented Apr 17, 2023

Pull Request Test Coverage Report for Build 4720189089

4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 4677293015:	0.0%
Covered Lines:	573
Relevant Lines:	573

💛 - Coveralls

Fdawgs merged commit 031848b into main

Fdawgs deleted the perf/includes branch

April 17, 2023 18:20

github-actions bot mentioned this pull request

chore(main): release 10.0.14 #1416

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet