Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSR-12, docblocks and add proper arguments types in ContainerInterface #7

Closed

Conversation

ArrMeeR
Copy link
Contributor

@ArrMeeR ArrMeeR commented Jun 22, 2021

I found a few little mistakes while browsing the framework's code :)

@jpresutti
Copy link
Contributor

jpresutti commented Jun 22, 2021

@ArrMeeR, the files you modified here were copied as is from the repos in https://github.com/php-fig and are deliberately untouched. While I would love for them to follow those standards and approve this PR, because of the nature of them being externally defined interfaces, I can't.

If you have any other things you wish to work on though, PLEASE by all means do.

(For anyone wondering why the interfaces were included directly, to allow ease of install for people who don't wish to use composer)

@jpresutti jpresutti closed this Jun 22, 2021
@ArrMeeR ArrMeeR deleted the fix-psr-12-and-docblocks branch June 23, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants