-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates TimeSincePrevious and Diff Primitives #561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 96.36% 96.35% -0.01%
==========================================
Files 116 116
Lines 9262 9244 -18
==========================================
- Hits 8925 8907 -18
Misses 337 337
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the tests that used Diff / TimeSincePrevious should use GroupByTransformFeature
so that we do not need to change the test answers.
fixed issues brought up by @rwedge |
…s before with new functionality
@rwedge fixed test cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@kmax12 fixed the timesinceprevious units and removed the diff date example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #501