Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization after adding interesting values #798

Merged
merged 18 commits into from Nov 18, 2019
Merged

Fix serialization after adding interesting values #798

merged 18 commits into from Nov 18, 2019

Conversation

@frances-h
Copy link
Contributor

frances-h commented Nov 5, 2019

Resolves issue #784 and adds a deep equality check to variables to verify interesting_values match

@frances-h frances-h requested a review from rwedge Nov 5, 2019
@frances-h frances-h self-assigned this Nov 5, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Nov 5, 2019

CLA assistant check
All committers have signed the CLA.

@frances-h frances-h changed the title Issue#784 Fix serialization after adding interesting values Nov 5, 2019
frances-h added 2 commits Nov 5, 2019
docs/source/changelog.rst Outdated Show resolved Hide resolved
featuretools/entityset/deserialize.py Outdated Show resolved Hide resolved
featuretools/entityset/serialize.py Outdated Show resolved Hide resolved
Copy link
Collaborator

rwedge left a comment

Can we add a test where interesting values are set by modifying the attribute directly instead of calling add_interesting_values?

frances-h added 4 commits Nov 11, 2019
frances-h added 3 commits Nov 14, 2019
frances-h added 5 commits Nov 14, 2019
@rwedge
rwedge approved these changes Nov 18, 2019
Copy link
Collaborator

rwedge left a comment

Looks good

@frances-h frances-h merged commit bd5973f into master Nov 18, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the issue#784 branch Nov 18, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.