Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization after adding interesting values #798

Merged
merged 18 commits into from
Nov 18, 2019
Merged

Fix serialization after adding interesting values #798

merged 18 commits into from
Nov 18, 2019

Conversation

frances-h
Copy link
Contributor

Resolves issue #784 and adds a deep equality check to variables to verify interesting_values match

@frances-h frances-h requested a review from rwedge November 5, 2019 17:23
@frances-h frances-h self-assigned this Nov 5, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@frances-h frances-h changed the title Issue#784 Fix serialization after adding interesting values Nov 5, 2019
rwedge
rwedge reviewed Nov 7, 2019
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
featuretools/entityset/deserialize.py Outdated Show resolved Hide resolved
featuretools/entityset/serialize.py Outdated Show resolved Hide resolved
rwedge
rwedge reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where interesting values are set by modifying the attribute directly instead of calling add_interesting_values?

rwedge
rwedge approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h merged commit bd5973f into master Nov 18, 2019
@frances-h frances-h deleted the issue#784 branch November 18, 2019 17:31
@rwedge rwedge mentioned this pull request Nov 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@frances-h frances-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frances-h @CLAassistant @rwedge