Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes necessary for docs to build for improved objectives project #605

Merged
merged 7 commits into from Apr 9, 2020

Conversation

angela97lin
Copy link
Contributor

Fixes documentation for improved_objectives branch.

@angela97lin angela97lin changed the base branch from master to improved_objectives April 8, 2020 21:52
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #605 into improved_objectives will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           improved_objectives     #605   +/-   ##
====================================================
  Coverage                98.81%   98.81%           
====================================================
  Files                      130      130           
  Lines                     4713     4713           
====================================================
  Hits                      4657     4657           
  Misses                      56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9fbf2...51143ad. Read the comment docs.

@angela97lin angela97lin requested a review from dsherry April 8, 2020 22:24
docs/source/changelog.rst Outdated Show resolved Hide resolved
* Pipelines will now no longer take an objective parameter during instantiation, and will no longer have an objective attribute.
* ``fit()`` and ``predict()`` now use an optional ``objective`` parameter, which is only used in binary classification pipelines to fit for a specific objective.
* ``score()`` will now use a required ``objectives`` parameter that is used to determine all the objectives to score on. This differs from the previous behavior, where the pipeline's objective was scored on regardless.
* ``score()`` will now return one dictionary of all objective scores.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin oops I think you have a duplicate entry here lol. This stuff should just go in Future, not in 0.8.0

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments about the changelog, one which blocks merge IMO, but otherwise looks good, 🚢 !

@angela97lin angela97lin merged commit 2fe7733 into improved_objectives Apr 9, 2020
angela97lin added a commit that referenced this pull request Apr 13, 2020
* Objectives API: Create new binary / multiclass pipeline classes and remove objectives from pipeline classes (#405)

* Objectives API: Remove ROC and confusion matrix as objectives (#422)

* Change `score` output to return one dictionary (#429)

* Create binary and multiclass objective classes  (#504)

* Update dependencies  (#412)

* Hide features with zero importance in plot by default (#413)

* Update dependencies check: package whitelist (#417)

* Add fixes necessary for docs to build for improved objectives project (#605)

* Remove calculating plot metrics from AutoML  (#615)
@dsherry dsherry deleted the improved_objectives_docs branch October 29, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants